[jboss-cvs] JBossAS SVN: r87094 - projects/aop/branches/Branch_2_1/aop/src/main/java/org/jboss/aop.

[jboss-cvs-commits at lists.jboss.org]

Author: flavia.rainone at jboss.com
Date: 2009-04-09 13:21:15 -0400 (Thu, 09 Apr 2009)
New Revision: 87094

Modified:
   projects/aop/branches/Branch_2_1/aop/src/main/java/org/jboss/aop/AspectManager.java
Log:
[JBAOP-717] The lock.lockRead() call has been included inside the synchronized block.

Modified: projects/aop/branches/Branch_2_1/aop/src/main/java/org/jboss/aop/AspectManager.java
===================================================================
--- projects/aop/branches/Branch_2_1/aop/src/main/java/org/jboss/aop/AspectManager.java	2009-04-09 17:04:08 UTC (rev 87093)
+++ projects/aop/branches/Branch_2_1/aop/src/main/java/org/jboss/aop/AspectManager.java	2009-04-09 17:21:15 UTC (rev 87094)
@@ -1043,10 +1043,10 @@
          {
             return null;
          }
-         lock.lockRead();
-         try
-         {
-            synchronized(this){
+         synchronized(this){
+	         lock.lockRead();
+	         try
+	         {
                if (weavingStrategy == null)
                {
                   if (TransformerCommon.isCompileTime())
@@ -1063,14 +1063,13 @@
                      weavingStrategy = new ClassicWeavingStrategy();
                   }
                }
-      
                return weavingStrategy.translate(this, className, loader, classfileBuffer);
             }
+	         finally
+	         {
+	            lock.unlockRead();
+	         }
          }
-         finally
-         {
-            lock.unlockRead();
-         }
       }
       catch (Exception e)
       {