[jboss-cvs] JBossAS SVN: r87668 - branches/Branch_5_x/system/src/main/org/jboss/system/server/profileservice/persistence.

[jboss-cvs-commits at lists.jboss.org]

Author: emuckenhuber
Date: 2009-04-22 06:44:52 -0400 (Wed, 22 Apr 2009)
New Revision: 87668

Modified:
   branches/Branch_5_x/system/src/main/org/jboss/system/server/profileservice/persistence/AbstractManagedObjectPersistencePlugin.java
Log:
cleanup

Modified: branches/Branch_5_x/system/src/main/org/jboss/system/server/profileservice/persistence/AbstractManagedObjectPersistencePlugin.java
===================================================================
--- branches/Branch_5_x/system/src/main/org/jboss/system/server/profileservice/persistence/AbstractManagedObjectPersistencePlugin.java	2009-04-22 10:05:25 UTC (rev 87667)
+++ branches/Branch_5_x/system/src/main/org/jboss/system/server/profileservice/persistence/AbstractManagedObjectPersistencePlugin.java	2009-04-22 10:44:52 UTC (rev 87668)
@@ -60,6 +60,7 @@
    {
       if(valuePersistence == null)
          throw new IllegalArgumentException("null value persistence.");
+      
       this.valuePersistence = valuePersistence;
    }
    
@@ -146,7 +147,7 @@
       if(mo == null)
          throw new IllegalArgumentException("Null managed object.");
      
-
+      //
       Map<String, PersistedProperty> properties = getPersistedProperties(persisted);
       for(String propertyName : mo.getPropertyNames())
       {
@@ -156,6 +157,7 @@
          
          if(persistedProperty == null)
          {
+            // Create a new peristed property
             persistedProperty = createPersistedProperty(property);
          }
          
@@ -224,8 +226,7 @@
             metaType = metaValue.getMetaType();
          
          // Create the persisted value
-         PersistedValue value = null;
-            value = valuePersistence.createPersistedValue(metaValue, metaType, persisted.getValue());
+         PersistedValue value = createPersistedValue(metaValue, metaType, persisted.getValue());
          if(value != null)
          {
             persisted.setValue(value);
@@ -238,6 +239,20 @@
    }
    
    /**
+    * Create a persisted value. This delegates the value creation
+    * to the ValuePeristence.
+    * 
+    * @param metaValue the meta value
+    * @param metaType the meta type
+    * @param persisted the persisted value
+    * @return the created persisted value
+    */
+   private PersistedValue createPersistedValue(MetaValue metaValue, MetaType metaType, PersistedValue persisted)
+   {
+      return getValuePersistence().createPersistedValue(metaValue, metaType, persisted);
+   }
+   
+   /**
     * Does this property needs to be processed.
     * 
     * @param property the managed property
@@ -252,7 +267,7 @@
          return process;
       
       // Skip non configuration properties
-      if(! property.hasViewUse(ViewUse.CONFIGURATION))
+      if(property.hasViewUse(ViewUse.CONFIGURATION) == false)
       {
          if(trace)
             log.trace("Skip non configuration property: " + property.getName());
@@ -288,7 +303,6 @@
          throw new IllegalArgumentException("Null persisted managed object.");
       
       Map<String, PersistedProperty> properties = new HashMap<String, PersistedProperty>();
-      
       List<PersistedProperty> list = persisted.getProperties();
       if(list == null)
       {