[jboss-cvs] JBossAS SVN: r92525 - in projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc: util and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: jesper.pedersen
Date: 2009-08-18 09:08:53 -0400 (Tue, 18 Aug 2009)
New Revision: 92525

Modified:
   projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/deployers/ra/BeanValidation.java
   projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/util/ExtractUtil.java
   projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/util/Injection.java
Log:
Eliminate Findbugs warnings

Modified: projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/deployers/ra/BeanValidation.java
===================================================================
--- projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/deployers/ra/BeanValidation.java	2009-08-18 12:31:42 UTC (rev 92524)
+++ projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/deployers/ra/BeanValidation.java	2009-08-18 13:08:53 UTC (rev 92525)
@@ -74,12 +74,12 @@
       Set errors = null;
       if (groupsClasses == null)
       {
-         v.validate(object, Default.class);
+         errors = v.validate(object, Default.class);
       }
       else
       {
          Class[] vargs = (Class[])groupsClasses.toArray(new Class[groupsClasses.size()]);
-         v.validate(object, vargs);
+         errors = v.validate(object, vargs);
       }
       if (errors != null && errors.size() > 0)
       {

Modified: projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/util/ExtractUtil.java
===================================================================
--- projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/util/ExtractUtil.java	2009-08-18 12:31:42 UTC (rev 92524)
+++ projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/util/ExtractUtil.java	2009-08-18 13:08:53 UTC (rev 92525)
@@ -70,7 +70,8 @@
       if (target.exists())
          recursiveDelete(target);
 
-      target.mkdirs();
+      if (!target.mkdirs())
+         throw new IOException("Could not create " + target);
 
       JarFile jar = new JarFile(file);
       Enumeration<JarEntry> entries = jar.entries();
@@ -100,7 +101,8 @@
          }
          else
          {
-            copy.mkdirs();
+            if (!copy.mkdirs())
+               throw new IOException("Could not create " + copy);
          }
       }
 
@@ -110,8 +112,9 @@
    /**
     * Recursive delete
     * @param f The file handler
+    * @exception IOException Thrown if a file could not be deleted
     */
-   public static void recursiveDelete(File f)
+   public static void recursiveDelete(File f) throws IOException
    {
       if (f.exists())
       {
@@ -126,11 +129,13 @@
                } 
                else
                {
-                  files[i].delete();
+                  if (!files[i].delete())
+                     throw new IOException("Could not delete " + files[i]);
                }
             }
          }
-         f.delete();
+         if (!f.delete())
+            throw new IOException("Could not delete " + f);
       }
    }
 }

Modified: projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/util/Injection.java
===================================================================
--- projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/util/Injection.java	2009-08-18 12:31:42 UTC (rev 92524)
+++ projects/jboss-jca/trunk/sjc/src/main/java/org/jboss/jca/sjc/util/Injection.java	2009-08-18 13:08:53 UTC (rev 92525)
@@ -119,7 +119,7 @@
       }
 
       Method method = object.getClass().getMethod(methodName, parameterClass);
-      Object result = method.invoke(object, new Object[] {parameterValue});
+      method.invoke(object, new Object[] {parameterValue});
    }
 
    /**