[jboss-cvs] JBossAS SVN: r97244 - projects/jboss-classpool/trunk/src/main/java/org/jboss/classpool/plugins/as5/jbosscl.

[jboss-cvs-commits at lists.jboss.org]

Author: alesj
Date: 2009-12-01 11:19:45 -0500 (Tue, 01 Dec 2009)
New Revision: 97244

Modified:
   projects/jboss-classpool/trunk/src/main/java/org/jboss/classpool/plugins/as5/jbosscl/JBossClClassPoolDomain.java
Log:
Why synched empty list?

Modified: projects/jboss-classpool/trunk/src/main/java/org/jboss/classpool/plugins/as5/jbosscl/JBossClClassPoolDomain.java
===================================================================
--- projects/jboss-classpool/trunk/src/main/java/org/jboss/classpool/plugins/as5/jbosscl/JBossClClassPoolDomain.java	2009-12-01 16:04:50 UTC (rev 97243)
+++ projects/jboss-classpool/trunk/src/main/java/org/jboss/classpool/plugins/as5/jbosscl/JBossClClassPoolDomain.java	2009-12-01 16:19:45 UTC (rev 97244)
@@ -47,18 +47,17 @@
 import org.jboss.classpool.spi.ClassPoolRepository;
 
 /**
- * 
+ * JBoss Cl class pool domain.
+ *
  * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
  * @author <a href="mailto:flavia.rainone at jboss.com">Flavia Rainone</a>
  * @version $Revision$
  */
 class JBossClClassPoolDomain extends BaseClassPoolDomain
 {
-   Map<String, Set<DelegatingClassPool>> poolsByPackage = new HashMap<String, Set<DelegatingClassPool>>();
-   final static List<DelegatingClassPool> EMPTY_LIST = Collections.unmodifiableList(Collections.EMPTY_LIST);
+   private Map<String, Set<DelegatingClassPool>> poolsByPackage = new HashMap<String, Set<DelegatingClassPool>>();
+   private DomainRegistry registry;
    
-   DomainRegistry registry;
-   
    public JBossClClassPoolDomain(String domainName, ParentPolicy parentPolicy, DomainRegistry registry)
    {
       super(domainName, 
@@ -219,11 +218,7 @@
    {
       String packageName = ClassLoaderUtils.getPackageName(classname);
       Set<DelegatingClassPool> poolSet = poolsByPackage.get(packageName);
-      if (poolSet == null)
-      {
-         return EMPTY_LIST;
-      }
-      return new ArrayList<DelegatingClassPool>(poolSet);
+      return (poolSet == null) ? Collections.<DelegatingClassPool>emptyList() : new ArrayList<DelegatingClassPool>(poolSet);
    }
 
    private CtClass getCtClassFromModule(final Module module, final String classname, boolean trace)
@@ -264,7 +259,7 @@
          }
          return pool.get(classname);
       }
-      catch(NotFoundException e)
+      catch(NotFoundException ignore)
       {
       }
       return null;