[jboss-cvs] Re: jboss-cvs-commits Digest, Vol 31, Issue 619

[Thomas Diesler]

 > depend on VFSDeploymentUnit, using it's VFS part

the change preserves this

-thomas


Ales Justin wrote:
> OK, this is trunk,
> but afaics you also applied this change to branch 5_0?
> 
> If so, this is breaking the api, as people might depend on 
> VFSDeploymentUnit, using it's VFS part, not just plain DU abstraction.
> 
> I have pieces in Seam-int that use this code.
> Fortunately it's not directly api based,
> so it actually doesn't break my code.
> 
>> ------------------------------
>>
>> Message: 3
>> Date: Sat, 31 Jan 2009 09:23:15 -0500
>> From: jboss-cvs-commits at lists.jboss.org
>> Subject: [jboss-cvs] JBossAS SVN: r83725 - in trunk:
>>     server/src/main/org/jboss/web/deployers and 2 other directories.
>> To: jboss-cvs-commits at lists.jboss.org
>> Message-ID: <E1LTGkd-0003IT-2T at committer01.frg.pub.inap.atl.jboss.com>
>> Content-Type: text/plain; charset=UTF-8
>>
>> Author: thomas.diesler at jboss.com
>> Date: 2009-01-31 09:23:14 -0500 (Sat, 31 Jan 2009)
>> New Revision: 83725
>>
>> Modified:
>>    trunk/server/src/main/org/jboss/web/WebApplication.java
>>    trunk/server/src/main/org/jboss/web/deployers/AbstractWarDeployer.java
>>    
>> trunk/server/src/main/org/jboss/web/deployers/AbstractWarDeployment.java
>>    trunk/server/src/main/org/jboss/web/deployers/WebModule.java
>>    
>> trunk/tomcat/src/main/org/jboss/web/tomcat/service/TomcatInjectionContainer.java 
>>
>>    
>> trunk/tomcat/src/main/org/jboss/web/tomcat/service/deployers/JBossContextConfig.java 
>>
>>    
>> trunk/tomcat/src/main/org/jboss/web/tomcat/service/deployers/TomcatDeployer.java 
>>
>>    
>> trunk/tomcat/src/main/org/jboss/web/tomcat/service/deployers/TomcatDeployment.java 
>>
>> Log:
>> [JBAS-6436] Fix in memory webapp deployment
>>
>> Modified: trunk/server/src/main/org/jboss/web/WebApplication.java
>> ===================================================================
>> --- trunk/server/src/main/org/jboss/web/WebApplication.java    
>> 2009-01-31 14:19:27 UTC (rev 83724)
>> +++ trunk/server/src/main/org/jboss/web/WebApplication.java    
>> 2009-01-31 14:23:14 UTC (rev 83725)
>> @@ -25,7 +25,7 @@
>>  import java.util.HashMap;
>>  import java.util.Map;
>>  
>> -import org.jboss.deployers.vfs.spi.structure.VFSDeploymentUnit;
>> +import org.jboss.deployers.structure.spi.DeploymentUnit;
>>  import org.jboss.metadata.web.jboss.JBossWebMetaData;
>>  
>>  /** A WebApplication represents the information for a war deployment.
>> @@ -39,7 +39,7 @@
>>  public class WebApplication
>>  {
>>     /** */
>> -   private VFSDeploymentUnit unit;
>> +   private DeploymentUnit unit;
>>     /** Class loader of this application */
>>     protected ClassLoader classLoader = null;
>>     /** name of this application */
>> @@ -102,11 +102,11 @@
>>        this.classLoader = classLoader;
>>     }
>>  
>> -   public VFSDeploymentUnit getDeploymentUnit()
>> +   public DeploymentUnit getDeploymentUnit()
>>     {
>>        return unit;
>>     }
>> -   public void setDeploymentUnit(VFSDeploymentUnit unit)
>> +   public void setDeploymentUnit(DeploymentUnit unit)
> 
> ...