[jboss-cvs] JBossAS SVN: r84637 - in trunk/profileservice/src/main/org/jboss/profileservice/management/upload: remoting and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: emuckenhuber
Date: 2009-02-23 11:10:47 -0500 (Mon, 23 Feb 2009)
New Revision: 84637

Modified:
   trunk/profileservice/src/main/org/jboss/profileservice/management/upload/AbstractDeploymentManager.java
   trunk/profileservice/src/main/org/jboss/profileservice/management/upload/SerializableDeploymentID.java
   trunk/profileservice/src/main/org/jboss/profileservice/management/upload/remoting/AbstractDeployHandler.java
   trunk/profileservice/src/main/org/jboss/profileservice/management/upload/remoting/StreamingDeploymentTarget.java
Log:
improve logging.

Modified: trunk/profileservice/src/main/org/jboss/profileservice/management/upload/AbstractDeploymentManager.java
===================================================================
--- trunk/profileservice/src/main/org/jboss/profileservice/management/upload/AbstractDeploymentManager.java	2009-02-23 16:10:15 UTC (rev 84636)
+++ trunk/profileservice/src/main/org/jboss/profileservice/management/upload/AbstractDeploymentManager.java	2009-02-23 16:10:47 UTC (rev 84637)
@@ -103,7 +103,7 @@
    }
    
    /**
-    * Stop deactivates and unregisteres the transient deployments profile.
+    * Stop deactivates and unregisters the transient deployments profile.
     */
    public void stop()
    {

Modified: trunk/profileservice/src/main/org/jboss/profileservice/management/upload/SerializableDeploymentID.java
===================================================================
--- trunk/profileservice/src/main/org/jboss/profileservice/management/upload/SerializableDeploymentID.java	2009-02-23 16:10:15 UTC (rev 84636)
+++ trunk/profileservice/src/main/org/jboss/profileservice/management/upload/SerializableDeploymentID.java	2009-02-23 16:10:47 UTC (rev 84637)
@@ -124,9 +124,9 @@
       buffer.append("names=").append(Arrays.toString(getNames()));
       // Only add the repositoryNames if it differs from deploymentNames
       if(getRepositoryNames() != getNames())
-         buffer.append("repositoryNames=").append(Arrays.toString(getRepositoryNames()));
-      buffer.append("copyContent=").append(copyContent);
-      buffer.append("description=").append(description);
+         buffer.append(", repositoryNames=").append(Arrays.toString(getRepositoryNames()));
+      buffer.append(", copyContent=").append(copyContent);
+      buffer.append(", description=").append(description);
       return buffer.toString();
    }
 }

Modified: trunk/profileservice/src/main/org/jboss/profileservice/management/upload/remoting/AbstractDeployHandler.java
===================================================================
--- trunk/profileservice/src/main/org/jboss/profileservice/management/upload/remoting/AbstractDeployHandler.java	2009-02-23 16:10:15 UTC (rev 84636)
+++ trunk/profileservice/src/main/org/jboss/profileservice/management/upload/remoting/AbstractDeployHandler.java	2009-02-23 16:10:47 UTC (rev 84637)
@@ -166,7 +166,9 @@
          catch(DeploymentException ignore) { }
          catch(Exception e)
          {
-            log.warn("Failed to process deployment: " + dtID, e);
+            // Server side logging
+            log.info("Failed to complete command: ["+ parameter +"] for deployment: " + dtID, e);
+            throw e;
          }
 
       }
@@ -270,7 +272,7 @@
       // Remove deployment
       deployer.removeDeployment(vfsd);
       
-      log.debug("Scheduling stop for: "+vfsd);
+      log.debug("Scheduling stop for: "+ vfsd);
    }
    
    /**

Modified: trunk/profileservice/src/main/org/jboss/profileservice/management/upload/remoting/StreamingDeploymentTarget.java
===================================================================
--- trunk/profileservice/src/main/org/jboss/profileservice/management/upload/remoting/StreamingDeploymentTarget.java	2009-02-23 16:10:15 UTC (rev 84636)
+++ trunk/profileservice/src/main/org/jboss/profileservice/management/upload/remoting/StreamingDeploymentTarget.java	2009-02-23 16:10:47 UTC (rev 84637)
@@ -195,15 +195,6 @@
          client.disconnect();
       }
    }
-
-   /**
-    * Undeploy a given module
-    */
-   @Deprecated
-   public void undeploy(DeploymentID dtID) throws Exception
-   {
-      remove(dtID);
-   }
    
    /**
     * Remove a given module.
@@ -231,9 +222,9 @@
       StringBuilder tmp = new StringBuilder();
       tmp.append("name=");
       tmp.append(name);
-      tmp.append(",locator=");
+      tmp.append(", locator=");
       tmp.append(locator);
-      tmp.append(",subsystem=");
+      tmp.append(", subsystem=");
       tmp.append(subsystem);
       return tmp.toString();
    }