[jboss-cvs] JBossAS SVN: r91393 - projects/ejb-book/trunk/ch07-rsscache/src/main/java/org/jboss/ejb3/examples/ch07/rsscache/impl/rome.

[jboss-cvs-commits at lists.jboss.org]

Author: ALRubinger
Date: 2009-07-18 00:19:09 -0400 (Sat, 18 Jul 2009)
New Revision: 91393

Modified:
   projects/ejb-book/trunk/ch07-rsscache/src/main/java/org/jboss/ejb3/examples/ch07/rsscache/impl/rome/RssCacheBean.java
Log:
[EJBBOOK-9] Set correct container lock defaults to WRITE, READ must be explicit

Modified: projects/ejb-book/trunk/ch07-rsscache/src/main/java/org/jboss/ejb3/examples/ch07/rsscache/impl/rome/RssCacheBean.java
===================================================================
--- projects/ejb-book/trunk/ch07-rsscache/src/main/java/org/jboss/ejb3/examples/ch07/rsscache/impl/rome/RssCacheBean.java	2009-07-18 03:27:18 UTC (rev 91392)
+++ projects/ejb-book/trunk/ch07-rsscache/src/main/java/org/jboss/ejb3/examples/ch07/rsscache/impl/rome/RssCacheBean.java	2009-07-18 04:19:09 UTC (rev 91393)
@@ -6,11 +6,11 @@
 import java.util.List;
 
 import javax.annotation.PostConstruct;
-import javax.annotation.Resource;
+import javax.ejb.ConcurrencyManagement;
+import javax.ejb.ConcurrencyManagementType;
 import javax.ejb.Lock;
 import javax.ejb.LockType;
 import javax.ejb.Remote;
-import javax.ejb.SessionContext;
 import javax.ejb.Singleton;
 import javax.ejb.Startup;
 
@@ -28,7 +28,7 @@
 /**
  * RssCacheBean
  * 
- * Singleton EJB, to be eagerly instanciated upon application deployment,
+ * Singleton EJB, to be eagerly instantiated upon application deployment,
  * exposing a cached view of an RSS Feed
  *
  * @author <a href="mailto:andrew.rubinger at jboss.org">ALR</a>
@@ -37,6 +37,8 @@
 @Singleton
 @Startup
 @Remote(RssCacheCommonBusiness.class)
+// Explicitly declare Container Managed Concurrency, which is unnecessary; it's the default
+ at ConcurrencyManagement(ConcurrencyManagementType.CONTAINER)
 public class RssCacheBean implements RssCacheCommonBusiness
 {
 
@@ -63,20 +65,15 @@
     */
    private List<RssEntry> entries;
 
-   /**
-    * The EJB SessionContext
-    */
-   @Resource
-   private SessionContext context;
-
    //-------------------------------------------------------------------------------------||
    // Required Implementations -----------------------------------------------------------||
    //-------------------------------------------------------------------------------------||
+
    /* (non-Javadoc)
     * @see org.jboss.ejb3.examples.ch07.rsscache.spi.RssCacheCommonBusiness#getEntries()
     */
    @Override
-   // @Lock(LockType.READ) // Optional metadata, READ is the default
+   @Lock(LockType.READ)
    public List<RssEntry> getEntries()
    {
       return entries;
@@ -85,7 +82,7 @@
    /* (non-Javadoc)
     * @see org.jboss.ejb3.examples.ch07.rsscache.spi.RssCacheCommonBusiness#getUrl()
     */
-   // @Lock(LockType.READ) // Optional metadata, READ is the default
+   @Lock(LockType.READ)
    @Override
    public URL getUrl()
    {
@@ -99,7 +96,7 @@
     */
    @PostConstruct
    @Override
-   // Lock all readers and writers until we're done here
+   // Lock all readers and writers until we're done here; Optional metadata, WRITE is the default
    @Lock(LockType.WRITE)
    public void refresh() throws IllegalStateException
    {