[jboss-cvs] JBoss Messaging SVN: r7226 - in trunk: src/main/org/jboss/messaging/core/remoting/impl and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: timfox
Date: 2009-06-05 10:13:10 -0400 (Fri, 05 Jun 2009)
New Revision: 7226

Modified:
   trunk/examples/core/perf/server0/jbm-configuration.xml
   trunk/src/main/org/jboss/messaging/core/remoting/impl/Pinger.java
Log:
Added comment

Modified: trunk/examples/core/perf/server0/jbm-configuration.xml
===================================================================
--- trunk/examples/core/perf/server0/jbm-configuration.xml	2009-06-05 13:39:55 UTC (rev 7225)
+++ trunk/examples/core/perf/server0/jbm-configuration.xml	2009-06-05 14:13:10 UTC (rev 7226)
@@ -20,6 +20,7 @@
    <journal-sync-non-transactional>true</journal-sync-non-transactional>
    <journal-type>ASYNCIO</journal-type>
    <journal-min-files>20</journal-min-files>
+   <journal-aio-buffer-timeout>20000</journal-aio-buffer-timeout>
 
    
    <queues>

Modified: trunk/src/main/org/jboss/messaging/core/remoting/impl/Pinger.java
===================================================================
--- trunk/src/main/org/jboss/messaging/core/remoting/impl/Pinger.java	2009-06-05 13:39:55 UTC (rev 7225)
+++ trunk/src/main/org/jboss/messaging/core/remoting/impl/Pinger.java	2009-06-05 14:13:10 UTC (rev 7226)
@@ -64,8 +64,12 @@
          return;
       }
       
-      //TODO - for now we *always* sent the ping otherwise, if we have large GC pauses
-      //can end up with pings not arriving at client in time
+      //TODO - for now we *always* sent the ping otherwise.
+      //Checking dataSent does not work, for the following reason:
+      //If a packet is sent just after the last ping, then no ping will be sent the next time.
+      //Which means the amount of time between pings can approach 2 * ( 0.5 * client failure check period) = failure check period
+      //so, due to time taken to actually travel across network + scheduling difference the client failure checker
+      //can easily time out.
       
 //      if (!conn.isDataSent())
 //      {