[jboss-cvs] JBossAS SVN: r90071 - in projects/jboss-reflect/trunk/src/main/java/org/jboss: beans/info/spi/helpers and 2 other directories.
jboss-cvs-commits at lists.jboss.org
jboss-cvs-commits at lists.jboss.org
Wed Jun 10 20:54:33 EDT 2009
Author: flavia.rainone at jboss.com
Date: 2009-06-10 20:54:33 -0400 (Wed, 10 Jun 2009)
New Revision: 90071
Modified:
projects/jboss-reflect/trunk/src/main/java/org/jboss/beans/info/spi/BeanInfoCreator.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/beans/info/spi/helpers/UnmodifiableBeanInfo.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistConstructorInfo.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistFieldInfo.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistMethodInfo.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistReflectionFactory.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfo.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/AbstractTypeInfo.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/DelegateClassInfo.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/PrimitiveInfo.java
Log:
[JBREFLECT-52] Some javadoc.
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/beans/info/spi/BeanInfoCreator.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/beans/info/spi/BeanInfoCreator.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/beans/info/spi/BeanInfoCreator.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -37,8 +37,19 @@
*/
interface BeanInfoCreator
{
+ /**
+ * Creates bean infos of type {@code AbstractBeanInfo}
+ */
static final BeanInfoCreator STANDARD = new StandardBeanInfoCreator();
+
+ /**
+ * Creates bean infos of type {@code FieldBeanInfo}
+ */
static final BeanInfoCreator FIELDS = new FieldBeanInfoCreator();
+
+ /**
+ * Creates bean infos of type {@code AllBeanInfo}
+ */
static final BeanInfoCreator ALL = new AllBeanInfoCreator();
/**
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/beans/info/spi/helpers/UnmodifiableBeanInfo.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/beans/info/spi/helpers/UnmodifiableBeanInfo.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/beans/info/spi/helpers/UnmodifiableBeanInfo.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -44,6 +44,11 @@
{
private BeanInfo delegate;
+ /**
+ * Constructor. Creates an unmodifiable view of {@code delegate}.
+ *
+ * @param delegate bean represented by the unmodifiable bean info created.
+ */
public UnmodifiableBeanInfo(BeanInfo delegate)
{
if (delegate == null)
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistConstructorInfo.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistConstructorInfo.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistConstructorInfo.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -40,10 +40,15 @@
import org.jboss.util.JBossStringBuilder;
/**
- * JavassistConstructor.
+ * ConstructorInfo that relies on Javassist to answer reflective queries and to invoke
+ * the represented constructor.
*
+ * This class also relies on Javassist to perform the instrumentation operations defined in
+ * {@code MutableConstructorInfo}
+ *
* @author <a href="adrian at jboss.com">Adrian Brock</a>
* @version $Revision$
+ * @see MutableConstructorInfo
*/
public class JavassistConstructorInfo extends JavassistAnnotatedParameterInfo implements MutableConstructorInfo
{
@@ -60,10 +65,10 @@
private transient JavassistConstructor constructor;
/**
- * Create a new JavassistConstructor.
+ * Create a new JavassistConstructorInfo.
*
* @param annotationHelper the annotation helper
- * @param typeInfo the type ifo
+ * @param typeInfo the type info
* @param ctConstructor the constructor
*/
public JavassistConstructorInfo(AnnotationHelper annotationHelper, JavassistTypeInfo typeInfo, CtConstructor ctConstructor)
@@ -71,7 +76,6 @@
super(annotationHelper);
this.typeInfo = typeInfo;
this.ctConstructor = ctConstructor;
-
}
public ModifierInfo getModifiers()
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistFieldInfo.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistFieldInfo.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistFieldInfo.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -35,10 +35,15 @@
import javassist.NotFoundException;
/**
- * JavassistFieldInfo.
+ * FieldInfo that relies on Javassist to answer reflective queries and to access
+ * the represented field.
*
+ * This class also relies on Javassist to perform the instrumentation operations defined in
+ * {@code MutableFieldInfo}.
+ *
* @author <a href="adrian at jboss.com">Adrian Brock</a>
* @version $Revision$
+ * @see MutableFieldInfo
*/
public class JavassistFieldInfo extends JavassistAnnotatedInfo implements MutableFieldInfo
{
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistMethodInfo.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistMethodInfo.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistMethodInfo.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -41,6 +41,18 @@
import org.jboss.reflect.spi.TypeInfo;
import org.jboss.util.JBossStringBuilder;
+
+/**
+ * MethodInfo that relies on Javassist to answer reflective queries and to invoke
+ * the represented method.
+ *
+ * This class also relies on Javassist to perform the instrumentation operations defined in
+ * {@code MutableMethodInfo}.
+ *
+ * @author <a href="adrian at jboss.com">Adrian Brock</a>
+ * @version $Revision$
+ * @see MutableMethodInfo
+ */
public class JavassistMethodInfo extends JavassistAnnotatedParameterInfo implements MutableMethodInfo
{
/** The serialVersionUID */
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistReflectionFactory.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistReflectionFactory.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistReflectionFactory.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -40,9 +40,12 @@
/**
* JavassistReflectionFactory.
+ * Creates instances of {@link JavassistMethod}, {@link JavassistConstructor} and
+ * {@link JavassistField} that invoke methods, constructors, and accesses fields without
+ * the use of reflection.
*
- * TODO JBMICROCONT-122 proper classpool with pruning
- * TODO JBMICROCONT-121 non compiler based implementation
+ * TODO JBREFLECT-3 proper classpool with pruning
+ * TODO JBREFLECT-6 non compiler based implementation
* @author <a href="adrian at jboss.com">Adrian Brock</a>
* @version $Revision$
*/
@@ -65,8 +68,11 @@
}
/**
- * Create a javassist method
+ * Creates a javassist method.
*
+ * This method generates an implementation of {@code JavassistMethod}, loads
+ * the generated class and instantiates it.
+ *
* @param ctMethod the method
* @return the method
* @throws Throwable for any error
@@ -76,7 +82,7 @@
//TODO: Fix this to use a more reasonable factory
ClassPool pool = JavassistTypeInfoFactoryImpl.poolFactory.getPoolForLoader(null);
final CtClass result = pool.makeClass(JavassistMethod.class.getName() + counter.incrementAndGet());
- /* TODO JBMICROCONT-133 figure out how to do this on all JDKs
+ /* TODO JBREFLECT-2 figure out how to do this on all JDKs
try
{
CtClass magic = pool.get("sun.reflect.MagicAccessorImpl");
@@ -260,6 +266,7 @@
final CtClass result = pool.makeClass(JavassistConstructor.class.getName() + counter.incrementAndGet());
try
{
+ // TODO JBREFLECT-2
CtClass magic = pool.get("sun.reflect.MagicAccessorImpl");
result.setSuperclass(magic);
}
@@ -384,6 +391,7 @@
// Fix this to use a better pool factory
ClassPool pool = JavassistTypeInfoFactoryImpl.poolFactory.getPoolForLoader(null);
final CtClass result = pool.makeClass(JavassistField.class.getName() + counter.incrementAndGet());
+ // TODO JBREFLECT-2
try
{
CtClass magic = pool.get("sun.reflect.MagicAccessorImpl");
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfo.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfo.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfo.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -188,7 +188,7 @@
public ClassInfo getGenericSuperclass()
{
- // TODO JBMICROCONT-129 getGenericSuperclass
+ // TODO JBREFLECT-5 getGenericSuperclass
throw new org.jboss.util.NotImplementedException("getGenericSuperclass");
}
@@ -212,7 +212,7 @@
public InterfaceInfo[] getGenericInterfaces()
{
- // TODO JBMICROCONT-129 getGenericInterfaces
+ // TODO JBREFLECT-5 getGenericInterfaces
throw new org.jboss.util.NotImplementedException("getGenericInterfaces");
}
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -466,7 +466,7 @@
if (type instanceof Class)
return getTypeInfo((Class<?>) type);
- // TODO JBMICROCONT-129 getTypeInfo + NumberInfo
+ // TODO JBREFLECT-5 getTypeInfo + NumberInfo
throw new org.jboss.util.NotImplementedException("getTypeInfo");
}
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/AbstractTypeInfo.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/AbstractTypeInfo.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/AbstractTypeInfo.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -26,10 +26,13 @@
/**
* AbstractTypeInfo.
+ *
+ * Contains a default implementation for the management of the attachments.
*
* @author <a href="adrian at jboss.com">Adrian Brock</a>
* @version $Revision: 1.1 $
*/
+ // TODO improve this class's javadoc
public abstract class AbstractTypeInfo extends JBossObject implements TypeInfo
{
/** The serialVersionUID */
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/DelegateClassInfo.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/DelegateClassInfo.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/DelegateClassInfo.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -55,6 +55,8 @@
*
* @param delegate the raw array info
* @param allowNull whether to allow a null delegate
+ * @throws IllegalArgumentException when {@code delegate} is {@code null} and
+ * {@code allowNull} equals {@code false}
*/
public DelegateClassInfo(ClassInfo delegate, boolean allowNull)
{
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/PrimitiveInfo.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/PrimitiveInfo.java 2009-06-10 23:36:00 UTC (rev 90070)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/spi/PrimitiveInfo.java 2009-06-11 00:54:33 UTC (rev 90071)
@@ -31,7 +31,7 @@
/**
* Primitive info
*
- * TODO JBMICROCONT-118 fix the introspection assumption
+ * TODO JBREFLECT-4 fix the introspection assumption
* @author <a href="mailto:bill at jboss.org">Bill Burke</a>
* @author <a href="mailto:adrian at jboss.org">Adrian Brock</a>
*/
More information about the jboss-cvs-commits
mailing list