[jboss-cvs] JBossAS SVN: r90440 - in projects/jboss-man/trunk/metatype/src: test/java/org/jboss/test/metatype and 4 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: bstansberry at jboss.com
Date: 2009-06-18 13:15:55 -0400 (Thu, 18 Jun 2009)
New Revision: 90440

Added:
   projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/
   projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/values/
   projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/values/mappers/
   projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/values/mappers/test/
   projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/values/mappers/test/PropertiesCompositeObjectNameMetaMapperUnitTestCase.java
Modified:
   projects/jboss-man/trunk/metatype/src/main/java/org/jboss/metatype/plugins/values/mappers/PropertiesCompositeObjectNameMetaMapper.java
Log:
[JBMAN-90] Unwrap the domain value before using it to create ObjectName

Modified: projects/jboss-man/trunk/metatype/src/main/java/org/jboss/metatype/plugins/values/mappers/PropertiesCompositeObjectNameMetaMapper.java
===================================================================
--- projects/jboss-man/trunk/metatype/src/main/java/org/jboss/metatype/plugins/values/mappers/PropertiesCompositeObjectNameMetaMapper.java	2009-06-18 16:59:42 UTC (rev 90439)
+++ projects/jboss-man/trunk/metatype/src/main/java/org/jboss/metatype/plugins/values/mappers/PropertiesCompositeObjectNameMetaMapper.java	2009-06-18 17:15:55 UTC (rev 90440)
@@ -76,7 +76,7 @@
    {
       CompositeValue compositeValue = (CompositeValue) metaValue;
       SimpleValue domain = (SimpleValue) compositeValue.get("domain");
-      String domainUnwrap = domain.toString();
+      String domainUnwrap = (String) domain.getValue();
       MetaValue keys = compositeValue.get("keyPropertyList");
       Hashtable keysUnwrap = null;
       if(keys instanceof PropertiesMetaValue)

Added: projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/values/mappers/test/PropertiesCompositeObjectNameMetaMapperUnitTestCase.java
===================================================================
--- projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/values/mappers/test/PropertiesCompositeObjectNameMetaMapperUnitTestCase.java	                        (rev 0)
+++ projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/values/mappers/test/PropertiesCompositeObjectNameMetaMapperUnitTestCase.java	2009-06-18 17:15:55 UTC (rev 90440)
@@ -0,0 +1,87 @@
+/*
+ * JBoss, Home of Professional Open Source.
+ * Copyright 2009, Red Hat Middleware LLC, and individual contributors
+ * as indicated by the @author tags. See the copyright.txt file in the
+ * distribution for a full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+
+package org.jboss.test.metatype.plugins.values.mappers.test;
+
+import java.util.Hashtable;
+
+import javax.management.MalformedObjectNameException;
+import javax.management.ObjectName;
+
+import junit.framework.TestCase;
+
+import org.jboss.metatype.api.values.MetaValue;
+import org.jboss.metatype.plugins.values.mappers.PropertiesCompositeObjectNameMetaMapper;
+import org.junit.Test;
+
+/**
+ *
+ *
+ * @author Brian Stansberry
+ * 
+ * @version $Revision: $
+ */
+public class PropertiesCompositeObjectNameMetaMapperUnitTestCase extends TestCase
+{
+   private PropertiesCompositeObjectNameMetaMapper mapper;
+   
+   
+   
+
+   @Override
+   protected void setUp() throws Exception
+   {
+      super.setUp();
+      
+      mapper = new PropertiesCompositeObjectNameMetaMapper();
+   }
+
+   /**
+    * Test method for {@link org.jboss.metatype.plugins.values.mappers.PropertiesCompositeObjectNameMetaMapper#mapToType()}.
+    */
+   public void testMapToType()
+   {
+      assertEquals(ObjectName.class, mapper.mapToType());
+   }
+
+   /**
+    * Tests that the result of a call to 
+    * {@link PropertiesCompositeObjectNameMetaMapper#createMetaValue(org.jboss.metatype.api.types.MetaType, ObjectName) createMetaValue} 
+    * passed to {@link PropertiesCompositeObjectNameMetaMapper#unwrapMetaValue(org.jboss.metatype.api.values.MetaValue) unwrapMetaValue}
+    * results in the equivalent object name as what was passed in.
+    */
+   public void testRoundTrip() throws MalformedObjectNameException
+   {
+      Hashtable<String, String> keys = new Hashtable<String, String>();
+      keys.put("key1", "value1");
+      keys.put("key1", "value1");
+      ObjectName input = new ObjectName("testRoundTrip", keys);
+      
+      MetaValue mv = mapper.createMetaValue(mapper.getMetaType(), input);
+      
+      ObjectName output = mapper.unwrapMetaValue(mv);
+      
+      assertEquals(input, output);
+      
+   }
+
+}


Property changes on: projects/jboss-man/trunk/metatype/src/test/java/org/jboss/test/metatype/plugins/values/mappers/test/PropertiesCompositeObjectNameMetaMapperUnitTestCase.java
___________________________________________________________________
Name: svn:keywords
   +