[jboss-cvs] JBossAS SVN: r90698 - branches/dml-log-service-integration/main/src/main/org/jboss.

[jboss-cvs-commits at lists.jboss.org]

Author: david.lloyd at jboss.com
Date: 2009-06-30 11:02:10 -0400 (Tue, 30 Jun 2009)
New Revision: 90698

Modified:
   branches/dml-log-service-integration/main/src/main/org/jboss/Main.java
Log:
Clean up some minor warnings, fix javadoc

Modified: branches/dml-log-service-integration/main/src/main/org/jboss/Main.java
===================================================================
--- branches/dml-log-service-integration/main/src/main/org/jboss/Main.java	2009-06-30 14:10:49 UTC (rev 90697)
+++ branches/dml-log-service-integration/main/src/main/org/jboss/Main.java	2009-06-30 15:02:10 UTC (rev 90698)
@@ -52,17 +52,6 @@
 /**
  * Provides a command line interface to start the JBoss server.
  *
- * <p>
- * To enable debug or trace messages durring boot change the Log4j
- * configuration to use either <tt>log4j-debug.properties</tt>
- * <tt>log4j-trace.properties</tt> by setting the system property
- * <tt>log4j.configuration</tt>:
- *
- * <pre>
- *   ./run.sh -Dlog4j.configuration=log4j-debug.properties
- * </pre>
- * TODO: Should jdk logging be the default
- *
  * @author <a href="mailto:marc.fleury at jboss.org">Marc Fleury</a>
  * @author <a href="mailto:jason at planet57.com">Jason Dillon</a>
  * @author <a href="mailto:adrian.brock at happeningtimes.com">Adrian Brock</a>
@@ -72,8 +61,6 @@
  */
 public class Main
 {
-   /** EDU.oswego.cs.dl.util.concurrent */
-   private String concurrentLib = "concurrent.jar";
 
    /** A URL for obtaining microkernel patches */
    private URL bootURL;
@@ -158,8 +145,6 @@
     */
    public Main()
    {
-      super();
-      
       // Set default properties
       final Properties sysProps = System.getProperties();
       for (final Object propName : sysProps.keySet())
@@ -317,9 +302,9 @@
       }
 
       // Add any extra libraries
-      for (int i = 0; i < bootLibraries.size(); i++)
+      for (URL bootLibrary : bootLibraries)
       {
-         urls.add(bootLibraries.get(i));
+         urls.add(bootLibrary);
       }
 
 //      // Add the jars from the endorsed dir
@@ -329,15 +314,15 @@
 //      loader.addLibrary(concurrentLib);
 
       // Add any extra libraries after the boot libs
-      for (int i = 0; i < extraLibraries.size(); i++)
+      for (URL extraLibrary : extraLibraries)
       {
-         urls.add(extraLibraries.get(i));
+         urls.add(extraLibrary);
       }
 
       // Add any extra classapth URLs
-      for (int i = 0; i < extraClasspath.size(); i++)
+      for (URL anExtraClasspath : extraClasspath)
       {
-         urls.add(extraClasspath.get(i));
+         urls.add(anExtraClasspath);
       }
       
       // Add all boot libs required from $JBOSS_HOME/lib
@@ -362,8 +347,7 @@
       }
       
       // Make a ClassLoader to be used in loading the server
-      final URL[] urlArray = urls.toArray(new URL[]
-      {});
+      final URL[] urlArray = urls.toArray(new URL[urls.size()]);
       final ClassLoader loadingCl = new URLClassLoader(urlArray, tccl);
 
       // Load the server
@@ -777,6 +761,11 @@
    @Deprecated
    private static class ServerConfigUtil
    {
+
+      private ServerConfigUtil()
+      {
+      }
+
       /**
        * Retrieve the default bind address for the server
        *