[jboss-cvs] JBossAS SVN: r85833 - in projects/jboss-jca/trunk: tools/findbugs and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: jesper.pedersen
Date: 2009-03-13 12:34:27 -0400 (Fri, 13 Mar 2009)
New Revision: 85833

Added:
   projects/jboss-jca/trunk/tools/findbugs/filter.xml
Modified:
   projects/jboss-jca/trunk/build.xml
Log:
[JBJCA-78] Integrate findbugs

Modified: projects/jboss-jca/trunk/build.xml
===================================================================
--- projects/jboss-jca/trunk/build.xml	2009-03-13 15:50:22 UTC (rev 85832)
+++ projects/jboss-jca/trunk/build.xml	2009-03-13 16:34:27 UTC (rev 85833)
@@ -190,13 +190,13 @@
 
     <findbugs home="${basedir}/tools/findbugs/lib/"
               output="xml:withMessages"
-              outputFile="${reports.dir}/findbugs/findbugs.xml" >
+              outputFile="${reports.dir}/findbugs/findbugs.xml" 
+              excludeFilter="${basedir}/tools/findbugs/filter.xml">
       <auxClasspath>
         <fileset dir="${lib.dir}/standalone">
           <include name="*.jar"/>
         </fileset>
       </auxClasspath>
-      <sourcePath path="${basedir}" />
       <class location="${target.dir}/javax-resource-spec-api.jar" />
       <class location="${target.dir}/jboss-jca-common-api.jar" />
       <class location="${target.dir}/jboss-jca-common-impl.jar" />

Added: projects/jboss-jca/trunk/tools/findbugs/filter.xml
===================================================================
--- projects/jboss-jca/trunk/tools/findbugs/filter.xml	                        (rev 0)
+++ projects/jboss-jca/trunk/tools/findbugs/filter.xml	2009-03-13 16:34:27 UTC (rev 85833)
@@ -0,0 +1,37 @@
+<FindBugsFilter>
+
+  <!-- javax.resource filter -->
+  <Match>
+    <Class name="javax.resource.Referenceable"/>
+    <Bug code="Nm"/>
+  </Match>
+  <Match>
+    <Class name="javax.resource.cci.ResultSet"/>
+    <Bug code="Nm"/>
+  </Match>
+  <Match>
+    <Class name="javax.resource.spi.InvalidPropertyException"/>
+    <Bug code="EI,EI2"/>
+  </Match>
+  <Match>
+    <Class name="javax.resource.spi.security.PasswordCredential"/>
+    <Bug code="EI"/>
+  </Match>
+
+  <!--  org.jboss.jca.common filter -->
+  <Match>
+    <Class name="org.jboss.jca.common.api.ThreadPool"/>
+    <Bug code="Nm"/>
+  </Match>
+
+  <!--  org.jboss.jca.core filter -->
+  <Match>
+    <Class name="org.jboss.jca.core.api.ConnectionManager"/>
+    <Bug code="Nm"/>
+  </Match>
+  <Match>
+    <Class name="org.jboss.jca.core.api.WorkManager"/>
+    <Bug code="Nm"/>
+  </Match>
+
+</FindBugsFilter>