[jboss-cvs] JBoss Messaging SVN: r6121 - in trunk/src/main/org/jboss/messaging: integration/transports/netty and 2 other directories.
jboss-cvs-commits at lists.jboss.org
jboss-cvs-commits at lists.jboss.org
Fri Mar 20 05:06:02 EDT 2009
Author: jmesnil
Date: 2009-03-20 05:06:02 -0400 (Fri, 20 Mar 2009)
New Revision: 6121
Modified:
trunk/src/main/org/jboss/messaging/core/management/MessageInfo.java
trunk/src/main/org/jboss/messaging/core/management/PairsInfo.java
trunk/src/main/org/jboss/messaging/core/management/PropertiesInfo.java
trunk/src/main/org/jboss/messaging/core/management/TransportConfigurationInfo.java
trunk/src/main/org/jboss/messaging/integration/transports/netty/NettyConnector.java
trunk/src/main/org/jboss/messaging/jms/server/management/JMSMessageInfo.java
trunk/src/main/org/jboss/messaging/jms/server/management/impl/TopicControl.java
Log:
code cleanup
* removed printStackTrace calls
Modified: trunk/src/main/org/jboss/messaging/core/management/MessageInfo.java
===================================================================
--- trunk/src/main/org/jboss/messaging/core/management/MessageInfo.java 2009-03-20 00:35:15 UTC (rev 6120)
+++ trunk/src/main/org/jboss/messaging/core/management/MessageInfo.java 2009-03-20 09:06:02 UTC (rev 6121)
@@ -42,6 +42,8 @@
import javax.management.openmbean.TabularDataSupport;
import javax.management.openmbean.TabularType;
+import org.jboss.messaging.core.logging.Logger;
+
/**
* @author <a href="mailto:jmesnil at redhat.com">Jeff Mesnil</a>
*
@@ -52,6 +54,8 @@
{
// Constants -----------------------------------------------------
+ private static final Logger log = Logger.getLogger(MessageInfo.class);
+
public static final CompositeType TYPE;
private static final String MESSAGE_TYPE_NAME = "MessageInfo";
@@ -106,7 +110,6 @@
}
catch (OpenDataException e)
{
- e.printStackTrace();
throw new IllegalStateException(e);
}
}
@@ -292,7 +295,7 @@
}
catch (OpenDataException e)
{
- e.printStackTrace();
+ log.error("Exception when converting a message to a CompositeData", e);
return null;
}
}
Modified: trunk/src/main/org/jboss/messaging/core/management/PairsInfo.java
===================================================================
--- trunk/src/main/org/jboss/messaging/core/management/PairsInfo.java 2009-03-20 00:35:15 UTC (rev 6120)
+++ trunk/src/main/org/jboss/messaging/core/management/PairsInfo.java 2009-03-20 09:06:02 UTC (rev 6121)
@@ -37,6 +37,7 @@
import javax.management.openmbean.TabularDataSupport;
import javax.management.openmbean.TabularType;
+import org.jboss.messaging.core.logging.Logger;
import org.jboss.messaging.utils.Pair;
/**
@@ -51,6 +52,8 @@
{
// Constants -----------------------------------------------------
+ private static final Logger log = Logger.getLogger(PairsInfo.class);
+
public static final TabularType TABULAR_TYPE;
private static CompositeType ROW_TYPE;
@@ -68,7 +71,6 @@
}
catch (OpenDataException e)
{
- e.printStackTrace();
throw new IllegalStateException(e);
}
}
@@ -129,7 +131,7 @@
}
catch (OpenDataException e)
{
- e.printStackTrace();
+ log.error("Exception when converting a collection of pairs to a TabularData", e);
return null;
}
}
Modified: trunk/src/main/org/jboss/messaging/core/management/PropertiesInfo.java
===================================================================
--- trunk/src/main/org/jboss/messaging/core/management/PropertiesInfo.java 2009-03-20 00:35:15 UTC (rev 6120)
+++ trunk/src/main/org/jboss/messaging/core/management/PropertiesInfo.java 2009-03-20 09:06:02 UTC (rev 6121)
@@ -24,10 +24,8 @@
import static javax.management.openmbean.SimpleType.STRING;
-import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
-import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
@@ -40,7 +38,7 @@
import javax.management.openmbean.TabularDataSupport;
import javax.management.openmbean.TabularType;
-import org.jboss.messaging.core.config.cluster.BroadcastGroupConfiguration;
+import org.jboss.messaging.core.logging.Logger;
/**
* Info for a Message property.
@@ -54,6 +52,8 @@
{
// Constants -----------------------------------------------------
+ private static final Logger log = Logger.getLogger(PropertiesInfo.class);
+
public static final TabularType TABULAR_TYPE;
private static CompositeType ROW_TYPE;
@@ -68,7 +68,6 @@
"Properties of the message", ROW_TYPE, new String[] { "key" });
} catch (OpenDataException e)
{
- e.printStackTrace();
throw new IllegalStateException(e);
}
}
@@ -118,7 +117,7 @@
return data;
} catch (OpenDataException e)
{
- e.printStackTrace();
+ log.error("Exception when converting a collection of properties to a TabularData", e);
return null;
}
}
Modified: trunk/src/main/org/jboss/messaging/core/management/TransportConfigurationInfo.java
===================================================================
--- trunk/src/main/org/jboss/messaging/core/management/TransportConfigurationInfo.java 2009-03-20 00:35:15 UTC (rev 6120)
+++ trunk/src/main/org/jboss/messaging/core/management/TransportConfigurationInfo.java 2009-03-20 09:06:02 UTC (rev 6121)
@@ -40,6 +40,7 @@
import javax.management.openmbean.TabularType;
import org.jboss.messaging.core.config.TransportConfiguration;
+import org.jboss.messaging.core.logging.Logger;
/**
* @author <a href="mailto:jmesnil at redhat.com">Jeff Mesnil</a>
@@ -51,6 +52,8 @@
{
// Constants -----------------------------------------------------
+ private static final Logger log = Logger.getLogger(TransportConfigurationInfo.class);
+
public static final CompositeType TYPE;
private static final String MESSAGE_TYPE_NAME = "TransportConfigurationInfo";
@@ -84,7 +87,6 @@
}
catch (OpenDataException e)
{
- e.printStackTrace();
throw new IllegalStateException(e);
}
}
@@ -146,7 +148,7 @@
}
catch (OpenDataException e)
{
- e.printStackTrace();
+ log.error("Exception when converting a TransportConfiguration to a CompositeData", e);
return null;
}
}
Modified: trunk/src/main/org/jboss/messaging/integration/transports/netty/NettyConnector.java
===================================================================
--- trunk/src/main/org/jboss/messaging/integration/transports/netty/NettyConnector.java 2009-03-20 00:35:15 UTC (rev 6120)
+++ trunk/src/main/org/jboss/messaging/integration/transports/netty/NettyConnector.java 2009-03-20 09:06:02 UTC (rev 6121)
@@ -398,7 +398,6 @@
}
else
{
- future.getCause().printStackTrace();
return null;
}
}
Modified: trunk/src/main/org/jboss/messaging/jms/server/management/JMSMessageInfo.java
===================================================================
--- trunk/src/main/org/jboss/messaging/jms/server/management/JMSMessageInfo.java 2009-03-20 00:35:15 UTC (rev 6120)
+++ trunk/src/main/org/jboss/messaging/jms/server/management/JMSMessageInfo.java 2009-03-20 09:06:02 UTC (rev 6121)
@@ -38,6 +38,7 @@
import javax.management.openmbean.TabularDataSupport;
import javax.management.openmbean.TabularType;
+import org.jboss.messaging.core.logging.Logger;
import org.jboss.messaging.core.management.PropertiesInfo;
import org.jboss.messaging.core.server.ServerMessage;
import org.jboss.messaging.jms.client.JBossMessage;
@@ -53,6 +54,8 @@
{
// Constants -----------------------------------------------------
+ private static final Logger log = Logger.getLogger(JMSMessageInfo.class);
+
public static final CompositeType TYPE;
private static final String MESSAGE_TYPE_NAME = "JMSMessageInfo";
private static final String MESSAGE_TABULAR_TYPE_NAME = "JMSMessageTabularInfo";
@@ -79,7 +82,6 @@
new String[] { "JMSMessageID" });
} catch (OpenDataException e)
{
- e.printStackTrace();
throw new IllegalStateException(e);
}
}
@@ -227,7 +229,7 @@
timestamp, jmsType, expiration, properties.toTabularData() });
} catch (OpenDataException e)
{
- e.printStackTrace();
+ log.error("Exception when converting a JMS Message to a CompositeData", e);
return null;
}
}
Modified: trunk/src/main/org/jboss/messaging/jms/server/management/impl/TopicControl.java
===================================================================
--- trunk/src/main/org/jboss/messaging/jms/server/management/impl/TopicControl.java 2009-03-20 00:35:15 UTC (rev 6120)
+++ trunk/src/main/org/jboss/messaging/jms/server/management/impl/TopicControl.java 2009-03-20 09:06:02 UTC (rev 6121)
@@ -305,7 +305,6 @@
}
catch (Exception e)
{
- e.printStackTrace();
return Collections.emptyList();
}
}
More information about the jboss-cvs-commits
mailing list