[jboss-cvs] JBossAS SVN: r96567 - in projects/kernel/trunk: aop-mc-int/src/test/java/org/jboss/test/microcontainer/support and 25 other directories.
Kabir Khan
kabir.khan at jboss.com
Thu Nov 19 14:41:36 EST 2009
On 19 Nov 2009, at 16:39, Adrian Brock wrote:
> Which version of eclipse are you using and which JDK?
Eclipse 3.4 w/ JDK 5
>
> What do you have configured in
> Window/Preferences/Java/Errors And Warnings/GenericTypes?
I've attached some screenshots
>
> Can give me a concrete example of one that is wrong?
For example this in WeldInjector
@SuppressWarnings("unchecked")
void preDestroy(Object instance) {
if (instance == null)
throw new IllegalArgumentException("Null instance");
it.preDestroy((T)instance);
creationalContext.release();
}
I get a warning about the SuppressWarnings not being needed, if I remove the @SuppressWarnings there is one less warning in my list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Annotations.jpg
Type: image/jpg
Size: 84702 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jboss-cvs-commits/attachments/20091119/58765da3/attachment.jpg
-------------- next part --------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Codestyle_and_problems.jpg
Type: image/jpg
Size: 129229 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jboss-cvs-commits/attachments/20091119/58765da3/attachment-0001.jpg
-------------- next part --------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Name_shadowing_deprecation.jpg
Type: image/jpg
Size: 110651 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jboss-cvs-commits/attachments/20091119/58765da3/attachment-0002.jpg
-------------- next part --------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Unnecessary_code_Generics.jpg
Type: image/jpg
Size: 118469 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jboss-cvs-commits/attachments/20091119/58765da3/attachment-0003.jpg
-------------- next part --------------
>
> On Thu, 2009-11-19 at 16:38 +0000, Kabir Khan wrote:
>> Hi Adrian,
>>
>> Why all the @SuppressWarnings? They show up in my Eclipse as Unnecessary @SuppressWarnings("unchecked"), so I now have 69 warnings instead of the <10 I had before updating.
>>
>> On 19 Nov 2009, at 13:46, jboss-cvs-commits at lists.jboss.org wrote:
>>
>>> Author: adrian at jboss.org
>>> Date: 2009-11-19 08:46:21 -0500 (Thu, 19 Nov 2009)
>>> New Revision: 96567
>>>
>>> Modified:
>>> projects/kernel/trunk/aop-mc-int/src/test/java/org/jboss/test/aop/junit/AnnotatedAOPMicrocontainerTestDelegate.java
>>> projects/kernel/trunk/aop-mc-int/src/test/java/org/jboss/test/microcontainer/support/LifecycleCallback.java
>>> projects/kernel/trunk/guice-int/src/main/java/org/jboss/guice/spi/GuiceKernelRegistryEntryPlugin.java
>>> projects/kernel/trunk/jmx-aop-mc-int/src/main/java/org/jboss/system/microcontainer/jmx/AbstractServiceControllerLifecycleCallback.java
>>> projects/kernel/trunk/jmx-mc-int/src/main/java/org/jboss/system/metadata/AbstractMetaDataVisitorNode.java
>>> projects/kernel/trunk/jmx-mc-int/src/test/java/org/jboss/test/system/metadata/value/valuefactory/test/ValueFactoryParsingUnitTestCase.java
>>> projects/kernel/trunk/jmx-mc-int/src/test/java/org/jboss/test/system/metadata/value/valuefactory/test/ValueFactoryTypeAnalysisUnitTestCase.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/api/annotations/MapValue.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/plugins/AbstractDependencyMetaData.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/plugins/AbstractInstallMetaData.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/spi/builder/BeanMetaDataBuilder.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/spi/factory/GenericBeanFactoryMetaData.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/BasicBeanAnnotationAdapter.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/BasicBeanMetaDataAnnotationAdapter.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/wb/CompositeKey.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/dependency/AbstractKernelController.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/dependency/KernelScopeInfo.java
>>> projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/deployment/props/TreeVertex.java
>>> projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/annotations/test/constructor/AnnotatedConstructorTestCase.java
>>> projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/ArrayTestCase.java
>>> projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/CollectionTestCase.java
>>> projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/InstantiateTestCase.java
>>> projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/support/container/BeanPool.java
>>> projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/support/container/plugin/GenericComponentFactory.java
>>> projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/test/BeanContainerUsageTestCase.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotated.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedCallable.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedMember.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedMethod.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedParameter.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedType.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotations/WeldEnabledBeanAnnotationPluginInitializer.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/dependency/WeldInjector.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/metadata/WeldDependencyMetaData.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExisitingInstanceFieldProducer.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExisitingInstanceMethodProducer.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceHolder.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceInjectionTarget.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceProducer.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/WeldFromMcRegistry.java
>>> projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/spi/annotated/MDRAnnotatedTypeFactory.java
>>> projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/AbstractWeldMcTest.java
>>> projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/WeldMcTestDelegate.java
>>> projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/annotated/test/AnnotatedTypeTestCase.java
>>> Log:
>>> Source code tidyup
>>>
>>> Modified: projects/kernel/trunk/aop-mc-int/src/test/java/org/jboss/test/aop/junit/AnnotatedAOPMicrocontainerTestDelegate.java
>>> ===================================================================
>>> --- projects/kernel/trunk/aop-mc-int/src/test/java/org/jboss/test/aop/junit/AnnotatedAOPMicrocontainerTestDelegate.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/aop-mc-int/src/test/java/org/jboss/test/aop/junit/AnnotatedAOPMicrocontainerTestDelegate.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -160,6 +160,7 @@
>>> *
>>> * @throws Exception for any error
>>> */
>>> + @SuppressWarnings("unchecked")
>>> protected void deployAOP() throws Exception
>>> {
>>> log.debug("Deploying annotations from " + tempDir);
>>>
>>> Modified: projects/kernel/trunk/aop-mc-int/src/test/java/org/jboss/test/microcontainer/support/LifecycleCallback.java
>>> ===================================================================
>>> --- projects/kernel/trunk/aop-mc-int/src/test/java/org/jboss/test/microcontainer/support/LifecycleCallback.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/aop-mc-int/src/test/java/org/jboss/test/microcontainer/support/LifecycleCallback.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -54,6 +54,7 @@
>>> handle(context);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> private void handle(ControllerContext context)
>>> {
>>> if (context instanceof KernelControllerContext)
>>>
>>> Modified: projects/kernel/trunk/guice-int/src/main/java/org/jboss/guice/spi/GuiceKernelRegistryEntryPlugin.java
>>> ===================================================================
>>> --- projects/kernel/trunk/guice-int/src/main/java/org/jboss/guice/spi/GuiceKernelRegistryEntryPlugin.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/guice-int/src/main/java/org/jboss/guice/spi/GuiceKernelRegistryEntryPlugin.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -49,6 +49,7 @@
>>> injector = null;
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public KernelRegistryEntry getEntry(Object name)
>>> {
>>> KernelRegistryEntry entry = null;
>>>
>>> Modified: projects/kernel/trunk/jmx-aop-mc-int/src/main/java/org/jboss/system/microcontainer/jmx/AbstractServiceControllerLifecycleCallback.java
>>> ===================================================================
>>> --- projects/kernel/trunk/jmx-aop-mc-int/src/main/java/org/jboss/system/microcontainer/jmx/AbstractServiceControllerLifecycleCallback.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/jmx-aop-mc-int/src/main/java/org/jboss/system/microcontainer/jmx/AbstractServiceControllerLifecycleCallback.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -77,6 +77,7 @@
>>> * The install AOP lifecycle callback method
>>> *
>>> * @param context The context being installed.
>>> + * @throws Exception for any error
>>> */
>>> public abstract void install(ControllerContext context) throws Exception;
>>>
>>> @@ -84,6 +85,7 @@
>>> * The uninstall AOP lifecycle callback method
>>> *
>>> * @param context The context being uninstalled.
>>> + * @throws Exception for any error
>>> */
>>> public abstract void uninstall(ControllerContext context) throws Exception;
>>>
>>>
>>> Modified: projects/kernel/trunk/jmx-mc-int/src/main/java/org/jboss/system/metadata/AbstractMetaDataVisitorNode.java
>>> ===================================================================
>>> --- projects/kernel/trunk/jmx-mc-int/src/main/java/org/jboss/system/metadata/AbstractMetaDataVisitorNode.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/jmx-mc-int/src/main/java/org/jboss/system/metadata/AbstractMetaDataVisitorNode.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -49,8 +49,12 @@
>>> /**
>>> * This is a helper method so we don't have to explicitly
>>> * implement this on every sub-metadata class.
>>> + *
>>> + * @param valueContext the value context
>>> + * @return null by default
>>> + * @throws Throwable for any error
>>> */
>>> - @SuppressWarnings({"JavaDoc", "UnusedDeclaration"})
>>> + @SuppressWarnings({"UnusedDeclaration"})
>>> public Object ungetValue(ServiceValueContext valueContext) throws Throwable
>>> {
>>> return null;
>>>
>>> Modified: projects/kernel/trunk/jmx-mc-int/src/test/java/org/jboss/test/system/metadata/value/valuefactory/test/ValueFactoryParsingUnitTestCase.java
>>> ===================================================================
>>> --- projects/kernel/trunk/jmx-mc-int/src/test/java/org/jboss/test/system/metadata/value/valuefactory/test/ValueFactoryParsingUnitTestCase.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/jmx-mc-int/src/test/java/org/jboss/test/system/metadata/value/valuefactory/test/ValueFactoryParsingUnitTestCase.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -60,6 +60,7 @@
>>> assertValueFactoryValue(value, SIMPLE_LIST, DEFAULT);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testMinimal() throws Exception
>>> {
>>> ServiceValueMetaData value = unmarshallSingleValue();
>>> @@ -82,6 +83,7 @@
>>> assertValueFactoryValue(value, SIMPLE_LIST, null);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testNoParameter() throws Exception
>>> {
>>> ServiceValueMetaData value = unmarshallSingleValue();
>>>
>>> Modified: projects/kernel/trunk/jmx-mc-int/src/test/java/org/jboss/test/system/metadata/value/valuefactory/test/ValueFactoryTypeAnalysisUnitTestCase.java
>>> ===================================================================
>>> --- projects/kernel/trunk/jmx-mc-int/src/test/java/org/jboss/test/system/metadata/value/valuefactory/test/ValueFactoryTypeAnalysisUnitTestCase.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/jmx-mc-int/src/test/java/org/jboss/test/system/metadata/value/valuefactory/test/ValueFactoryTypeAnalysisUnitTestCase.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -75,6 +75,7 @@
>>> super.tearDown();
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testNoArgsMatch()
>>> {
>>> MethodInfo mi = new MockMethodInfo(METHOD, new TypeInfo[0]);
>>> @@ -158,6 +159,7 @@
>>> catch (IllegalArgumentException good) {}
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testNameMismatch()
>>> {
>>> MethodInfo mi = new MockMethodInfo(METHOD, new TypeInfo[0]);
>>> @@ -186,6 +188,7 @@
>>> catch (IllegalArgumentException good) {}
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testOneParamToZeroParams()
>>> {
>>> MethodInfo mi = new MockMethodInfo(METHOD, new TypeInfo[] { OBJECT_TYPE });
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/api/annotations/MapValue.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/api/annotations/MapValue.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/api/annotations/MapValue.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -31,7 +31,7 @@
>>> * <pre>
>>> * @MapValue(keyClass=java.lang.String.class,
>>> * valueClass=java.lang.String.class,
>>> - * {@EntryValue(key=@Value(string=@StringValue("foo.bar.key")),
>>> + * {@EntryValue(key=@Value(string=@StringValue("foo.bar.key")),
>>> * value=@Value(string=@StringValue("QWERT"))),
>>> * @EntryValue(key=@Value(string=@StringValue("xyz.key")),
>>> * value=@Value(string=@StringValue("QWERTY")))
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/plugins/AbstractDependencyMetaData.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/plugins/AbstractDependencyMetaData.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/plugins/AbstractDependencyMetaData.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -146,6 +146,7 @@
>>> * Create a new LifecycleDependencyItem.
>>> *
>>> * @param name the name
>>> + * @param dependency the name of the dependency
>>> * @param state the state
>>> */
>>> public LifecycleDependencyItem(Object name, Object dependency, ControllerState state)
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/plugins/AbstractInstallMetaData.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/plugins/AbstractInstallMetaData.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/plugins/AbstractInstallMetaData.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -160,6 +160,9 @@
>>> * Create a new InstallationDependencyItem.
>>> *
>>> * @param name the name
>>> + * @param bean the bean
>>> + * @param state the state of the bean
>>> + * @param dependentState the state of the dependency
>>> */
>>> public InstallationDependencyItem(Object name, String bean, ControllerState state, ControllerState dependentState)
>>> {
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/spi/builder/BeanMetaDataBuilder.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/spi/builder/BeanMetaDataBuilder.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/spi/builder/BeanMetaDataBuilder.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -966,7 +966,6 @@
>>> *
>>> * @see BeanMetaData#getInstalls()
>>> * @param methodName the name of the method to be called upon install
>>> - * @param methodName the method name
>>> * @param types the parameter types
>>> * @param values the parameter values
>>> * @return this builder
>>> @@ -1308,7 +1307,6 @@
>>> *
>>> * @see BeanMetaData#getUninstalls()
>>> * @param methodName the name of the method to be called upon uninstall
>>> - * @param methodName the method name
>>> * @param types the parameter types
>>> * @param values the parameter values
>>> * @return this builder
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/spi/factory/GenericBeanFactoryMetaData.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/spi/factory/GenericBeanFactoryMetaData.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/beans/metadata/spi/factory/GenericBeanFactoryMetaData.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -154,7 +154,7 @@
>>> /**
>>> * Get the name of the bean factory
>>> *
>>> - * @see BeanMetaData#getName(String)
>>> + * @see BeanMetaData#getName()
>>> * @return the name
>>> */
>>> public String getName()
>>> @@ -605,7 +605,7 @@
>>> * Get the bean metadata for the {@link BeanFactory} created by this bean factory metadata
>>> *
>>> * @see BeanMetaData#getUninstalls()
>>> - * @param uninstalls the uninstalls
>>> + * @return the bean metadata
>>> */
>>> @XmlTransient
>>> public BeanMetaData getBeanMetaData()
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/BasicBeanAnnotationAdapter.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/BasicBeanAnnotationAdapter.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/BasicBeanAnnotationAdapter.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -95,6 +95,7 @@
>>> addAnnotationPlugin(UninstallFieldCallbackAnnotationPlugin.INSTANCE);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void addAnnotationPlugin(AnnotationPlugin<?, ?> plugin)
>>> {
>>> super.addAnnotationPlugin(plugin);
>>> @@ -102,6 +103,7 @@
>>> addAnnotation2ValueMetaDataAdapter((Annotation2ValueMetaDataAdapter<? extends Annotation>)plugin);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void removeAnnotationPlugin(AnnotationPlugin<?, ?> plugin)
>>> {
>>> if (plugin instanceof Annotation2ValueMetaDataAdapter)
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/BasicBeanMetaDataAnnotationAdapter.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/BasicBeanMetaDataAnnotationAdapter.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/BasicBeanMetaDataAnnotationAdapter.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -84,6 +84,7 @@
>>> addAnnotationPlugin(UninstallFieldCallbackAnnotationPlugin.INSTANCE);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void addAnnotationPlugin(AnnotationPlugin<?, ?> plugin)
>>> {
>>> super.addAnnotationPlugin(plugin);
>>> @@ -91,6 +92,7 @@
>>> addAnnotation2ValueMetaDataAdapter((Annotation2ValueMetaDataAdapter<? extends Annotation>)plugin);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void removeAnnotationPlugin(AnnotationPlugin<?, ?> plugin)
>>> {
>>> if (plugin instanceof Annotation2ValueMetaDataAdapter)
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/wb/CompositeKey.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/wb/CompositeKey.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/annotations/wb/CompositeKey.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -98,6 +98,7 @@
>>> return getWeakPartHashCode() + getRestHashCode();
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public boolean equals(Object obj)
>>> {
>>> if (obj instanceof CompositeKey == false)
>>> @@ -178,6 +179,7 @@
>>> this.key = key;
>>> }
>>>
>>> + @SuppressWarnings("unused")
>>> public CompositeKey<T, U> getKey()
>>> {
>>> return key;
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/dependency/AbstractKernelController.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/dependency/AbstractKernelController.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/dependency/AbstractKernelController.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -108,6 +108,7 @@
>>> return context;
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public KernelRegistryEntry getEntry(Object name)
>>> {
>>> List<KernelControllerContext> list;
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/dependency/KernelScopeInfo.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/dependency/KernelScopeInfo.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/dependency/KernelScopeInfo.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -85,6 +85,7 @@
>>> }
>>>
>>> @Override
>>> + @SuppressWarnings("unchecked")
>>> public ScopeKey getScope()
>>> {
>>> // THIS IS A HACK - the scope originally gets initialise with a class name, we fix it to have the class
>>>
>>> Modified: projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/deployment/props/TreeVertex.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/deployment/props/TreeVertex.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/main/java/org/jboss/kernel/plugins/deployment/props/TreeVertex.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -47,6 +47,7 @@
>>> super(name);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void visit()
>>> {
>>> Vertex<String> parent = getParent(this);
>>> @@ -80,6 +81,7 @@
>>> * @param vertex the vertex to check
>>> * @return parent vertex
>>> */
>>> + @SuppressWarnings("unchecked")
>>> protected static Vertex<String> getParent(Vertex<String> vertex)
>>> {
>>> List<Edge<String>> edges = vertex.getIncomingEdges();
>>>
>>> Modified: projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/annotations/test/constructor/AnnotatedConstructorTestCase.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/annotations/test/constructor/AnnotatedConstructorTestCase.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/annotations/test/constructor/AnnotatedConstructorTestCase.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -84,6 +84,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotatedConstructorNoParameters() throws Throwable
>>> {
>>> AbstractBeanMetaData bmd = new AbstractBeanMetaData("Bean", AnnotatedConstructorBean.class.getName());
>>> @@ -134,6 +135,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotatedConstructorOneParameterAnnotationsOnConstructor() throws Throwable
>>> {
>>> AbstractBeanMetaData bmd = new AbstractBeanMetaData("Bean", AnnotatedConstructorBean.class.getName());
>>> @@ -162,6 +164,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotatedConstructorOneParameterAnnotationsOnConstructorAndParameter() throws Throwable
>>> {
>>> AbstractBeanMetaData bmd = new AbstractBeanMetaData("Bean", AnnotatedConstructorBean.class.getName());
>>> @@ -191,6 +194,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotatedConstructorOneParameterAnnotationsOnParameter() throws Throwable
>>> {
>>> AbstractBeanMetaData bmd = new AbstractBeanMetaData("Bean", AnnotatedConstructorBean.class.getName());
>>> @@ -219,6 +223,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotatedConstructorTwoConstructorAnnotations() throws Throwable
>>> {
>>> AbstractBeanMetaData bmd = new AbstractBeanMetaData("Bean", AnnotatedConstructorBean.class.getName());
>>> @@ -250,6 +255,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotatedConstructorTwoConstructorAndParameterOneAnnotations() throws Throwable
>>> {
>>> AbstractBeanMetaData bmd = new AbstractBeanMetaData("Bean", AnnotatedConstructorBean.class.getName());
>>> @@ -282,6 +288,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotatedConstructorTwoConstructorAndParameterTwoAnnotations() throws Throwable
>>> {
>>> AbstractBeanMetaData bmd = new AbstractBeanMetaData("Bean", AnnotatedConstructorBean.class.getName());
>>> @@ -314,6 +321,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotatedConstructorTwoConstructorAndParameterOneTwoAnnotations() throws Throwable
>>> {
>>> AbstractBeanMetaData bmd = new AbstractBeanMetaData("Bean", AnnotatedConstructorBean.class.getName());
>>>
>>> Modified: projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/ArrayTestCase.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/ArrayTestCase.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/ArrayTestCase.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -305,6 +305,7 @@
>>> return (SimpleBean) instantiateAndConfigure(configurator, bmd);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testArrayIsInterface() throws Throwable
>>> {
>>> SimpleBean bean = arrayIsInterface();
>>>
>>> Modified: projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/CollectionTestCase.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/CollectionTestCase.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/CollectionTestCase.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -390,6 +390,7 @@
>>> return (SimpleBean) instantiateAndConfigure(configurator, bmd);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testCollectionInjectOnObject() throws Throwable
>>> {
>>> SimpleBean bean = collectionInjectOnObject();
>>>
>>> Modified: projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/InstantiateTestCase.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/InstantiateTestCase.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/config/test/InstantiateTestCase.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -425,6 +425,7 @@
>>> return instantiate(configurator, bmd);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testValueInstantiateFromCollection() throws Throwable
>>> {
>>> Object object = valueInstantiateFromCollection();
>>> @@ -447,6 +448,7 @@
>>> return instantiate(configurator, bmd);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testValueInstantiateFromList() throws Throwable
>>> {
>>> Object object = valueInstantiateFromList();
>>> @@ -469,6 +471,7 @@
>>> return instantiate(configurator, bmd);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testValueInstantiateFromSet() throws Throwable
>>> {
>>> Object object = valueInstantiateFromSet();
>>>
>>> Modified: projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/support/container/BeanPool.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/support/container/BeanPool.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/support/container/BeanPool.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -69,6 +69,7 @@
>>> return pool.remainingCapacity();
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public synchronized T createBean()
>>> throws Throwable
>>> {
>>> @@ -93,6 +94,8 @@
>>> log.debug("End createBean, size: "+pool.size()+", bean: "+bean);
>>> return bean;
>>> }
>>> +
>>> + @SuppressWarnings("unchecked")
>>> public void destroyBean(T bean)
>>> throws Throwable
>>> {
>>>
>>> Modified: projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/support/container/plugin/GenericComponentFactory.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/support/container/plugin/GenericComponentFactory.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/support/container/plugin/GenericComponentFactory.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -61,6 +61,7 @@
>>> factoryContext = null;
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public ComponentInstance<T> createComponents(String baseName)
>>> throws Throwable
>>> {
>>>
>>> Modified: projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/test/BeanContainerUsageTestCase.java
>>> ===================================================================
>>> --- projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/test/BeanContainerUsageTestCase.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/kernel/src/test/java/org/jboss/test/kernel/deployment/test/BeanContainerUsageTestCase.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -65,6 +65,7 @@
>>> super(name);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testDependencyInjectionOfBean() throws Throwable
>>> {
>>> bootstrap();
>>> @@ -96,6 +97,8 @@
>>> assertNotNull(bean13Injected);
>>> deployer.shutdown();
>>> }
>>> +
>>> + @SuppressWarnings("unchecked")
>>> public void testDependencyInjectionOfBeanWithMismatchedPoolSizes()
>>> throws Throwable
>>> {
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotated.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotated.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotated.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -103,7 +103,7 @@
>>> /**
>>> * Gets an annotation
>>> *
>>> - * @param the annotation type to get
>>> + * @param annotationType the annotation type to get
>>> * @return the annotations from the delegate and the MDR metadata
>>> */
>>> public <T extends Annotation> T getAnnotation(Class<T> annotationType)
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedCallable.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedCallable.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedCallable.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -34,6 +34,7 @@
>>> /**
>>> * Decorator that understands MDR metadata for a method or constructor
>>> *
>>> + * @param <X> the declaring type
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedMember.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedMember.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedMember.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -30,6 +30,7 @@
>>> /**
>>> * Decorator that understands MDR metadata for a field, constructor or method
>>> *
>>> + * @param <X> ?
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>> @@ -59,6 +60,7 @@
>>> * @return the delegate
>>> */
>>> @Override
>>> + @SuppressWarnings("unchecked")
>>> AnnotatedMember<X> getDelegate()
>>> {
>>> return (AnnotatedMember<X>)super.getDelegate();
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedMethod.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedMethod.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedMethod.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -33,6 +33,7 @@
>>> /**
>>> * Decorator that understands MDR metadata for a method
>>> *
>>> + * @param <X> ?
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedParameter.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedParameter.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedParameter.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -30,6 +30,7 @@
>>> /**
>>> * Decorator that understands MDR metadata for a parameter
>>> *
>>> + * @param <X> ?
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>> @@ -56,6 +57,7 @@
>>> * @return the delegate
>>> */
>>> @Override
>>> + @SuppressWarnings("unchecked")
>>> AnnotatedParameter<X> getDelegate()
>>> {
>>> return (AnnotatedParameter<X>)super.getDelegate();
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedType.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedType.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotated/MDRAnnotatedType.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -128,6 +128,7 @@
>>> * @return the delegate
>>> */
>>> @Override
>>> + @SuppressWarnings("unchecked")
>>> AnnotatedType<X> getDelegate()
>>> {
>>> return (AnnotatedType<X>)super.getDelegate();
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotations/WeldEnabledBeanAnnotationPluginInitializer.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotations/WeldEnabledBeanAnnotationPluginInitializer.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/annotations/WeldEnabledBeanAnnotationPluginInitializer.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -34,12 +34,12 @@
>>> */
>>> public class WeldEnabledBeanAnnotationPluginInitializer extends AbstractBeanAnnotationAdapter
>>> {
>>> + @SuppressWarnings("unchecked")
>>> public static void initialize()
>>> {
>>> BeanAnnotationAdapter adapter = BeanAnnotationAdapterFactory.getInstance().getBeanAnnotationAdapter();
>>> if (adapter instanceof CommonAnnotationAdapter)
>>> {
>>> - @SuppressWarnings("unchecked")
>>> CommonAnnotationAdapter common = (CommonAnnotationAdapter)adapter;
>>> common.addAnnotationPlugin(WeldEnabledAnnotationPlugin.INSTANCE);
>>> }
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/dependency/WeldInjector.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/dependency/WeldInjector.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/dependency/WeldInjector.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -47,6 +47,7 @@
>>>
>>> /**
>>> *
>>> + * @param <T> the type of the injection target
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>> @@ -185,6 +186,7 @@
>>> /**
>>> * Performs injection from web beans into the bean
>>> */
>>> + @SuppressWarnings("unchecked")
>>> void inject()
>>> {
>>> if (injectInWeld)
>>> @@ -237,6 +239,7 @@
>>> * @param instance the instance
>>> * @throws IllegalArgumentException if the instance is null
>>> */
>>> + @SuppressWarnings("unchecked")
>>> void postConstruct(Object instance) {
>>> if (instance == null)
>>> throw new IllegalArgumentException("Null instance");
>>> @@ -250,6 +253,7 @@
>>> * @param instance the instance
>>> * @throws IllegalArgumentException if the instance is null
>>> */
>>> + @SuppressWarnings("unchecked")
>>> void preDestroy(Object instance) {
>>> if (instance == null)
>>> throw new IllegalArgumentException("Null instance");
>>> @@ -317,8 +321,10 @@
>>> {
>>> boolean matches(Annotation annotation);
>>>
>>> + @SuppressWarnings("unused")
>>> AnnotationChecker BINDING = new BindingAnnotationChecker();
>>>
>>> + @SuppressWarnings("unused")
>>> AnnotationChecker PRODUCER = new ProducerAnnotationChecker();
>>> }
>>>
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/metadata/WeldDependencyMetaData.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/metadata/WeldDependencyMetaData.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/metadata/WeldDependencyMetaData.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -63,6 +63,7 @@
>>> *
>>> * @param injectionPoint the injection point
>>> */
>>> + @SuppressWarnings("unchecked")
>>> public WeldDependencyMetaData(InjectionPoint injectionPoint)
>>> {
>>> super(injectionPoint);
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExisitingInstanceFieldProducer.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExisitingInstanceFieldProducer.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExisitingInstanceFieldProducer.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -31,6 +31,7 @@
>>>
>>> /**
>>> *
>>> + * @param <T> the class of the object produced by the producer
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>> @@ -45,6 +46,7 @@
>>> SecurityActions.setAccessible(field);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public T produce(CreationalContext<T> ctx)
>>> {
>>> try
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExisitingInstanceMethodProducer.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExisitingInstanceMethodProducer.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExisitingInstanceMethodProducer.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -31,6 +31,7 @@
>>>
>>> /**
>>> *
>>> + * @param <T> the class of the object produced by the producer
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>> @@ -45,6 +46,7 @@
>>> SecurityActions.setAccessible(method);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public T produce(CreationalContext<T> ctx)
>>> {
>>> try
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceHolder.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceHolder.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceHolder.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -29,6 +29,7 @@
>>>
>>> /**
>>> *
>>> + * @param <T> ?
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>> @@ -44,6 +45,7 @@
>>> this.context = context;
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> T getInstanceFromContext()
>>> {
>>> if (context == null)
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceInjectionTarget.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceInjectionTarget.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceInjectionTarget.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -31,6 +31,7 @@
>>>
>>> /**
>>> *
>>> + * @param <T> the class of the target
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceProducer.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceProducer.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/ExistingInstanceProducer.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -30,6 +30,7 @@
>>>
>>> /**
>>> *
>>> + * @param <T> the class of the object produced by the producer
>>> * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
>>> * @version $Revision: 1.1 $
>>> */
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/WeldFromMcRegistry.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/WeldFromMcRegistry.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/plugins/weld/WeldFromMcRegistry.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -157,6 +157,8 @@
>>>
>>> /**
>>> * Get a copy of all the MC beans that should be registered as web beans
>>> + *
>>> + * @return the collection of beans
>>> */
>>> public Collection<AnnotatedTypeWrapper> getTypes()
>>> {
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/spi/annotated/MDRAnnotatedTypeFactory.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/spi/annotated/MDRAnnotatedTypeFactory.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/main/java/org/jboss/kernel/weld/spi/annotated/MDRAnnotatedTypeFactory.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -50,6 +50,7 @@
>>> /**
>>> * Decorate an annotated type to understand MDR metadata
>>> *
>>> + * @param <T> the type of the delegate
>>> * @param delegate the type to decorate
>>> * @param metaData the MDR metadata for the bean for which we want to decorate the type
>>> * @return the type decorated with MDR metadata
>>> @@ -59,6 +60,7 @@
>>> /**
>>> * Decorate an annotated type to understand MDR metadata
>>> *
>>> + * @param <T> the type of the delegate
>>> * @param delegate the type to decorate
>>> * @param context the Kernel controller context which contains the metadata
>>> * @return the type decorated with MDR metadata
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/AbstractWeldMcTest.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/AbstractWeldMcTest.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/AbstractWeldMcTest.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -113,7 +113,7 @@
>>> * Initialises weld with the classes to be deployed in weld, and deploys them.
>>> * After this calls to {@link #getCurrentManager()} are valid.
>>> *
>>> - * @param extension the package containing the {@link #EXTENSION_FILE} if you want to deploy extensions
>>> + * @param extension the package containing the {@link WeldMcTestDelegate#EXTENSION_FILE} if you want to deploy extensions
>>> * @param classes the classes to be deployed as web beans
>>> * @throws IllegalStateException if weld was already initialized
>>> */
>>> @@ -127,7 +127,7 @@
>>> * After this calls to {@link #getCurrentManager()} are valid. To deploy
>>> * classes call {@link #deployInitializedWeld()}
>>> *
>>> - * @param extension the package containing the {@link #EXTENSION_FILE} if you want to deploy extensions
>>> + * @param extension the package containing the {@link WeldMcTestDelegate#EXTENSION_FILE} if you want to deploy extensions
>>> * @param classes the classes to be deployed as web beans
>>> * @throws IllegalStateException if weld was already initialized
>>> */
>>> @@ -183,7 +183,7 @@
>>> * Check that a collection has the expected size
>>> *
>>> * @param expected the expected size
>>> - * @param the collection to check
>>> + * @param collection the collection to check
>>> * @throws AssertionFailedError if the collection does not have the expected size
>>> */
>>> protected void assertSize(int expected, Collection<?> collection)
>>> @@ -205,6 +205,7 @@
>>> *
>>> * @param name the name of the bean
>>> * @param clazz the class of the bean
>>> + * @return the bean metadata
>>> */
>>> protected BeanMetaData createBeanMetaData(String name, Class<?> clazz)
>>> {
>>> @@ -218,6 +219,7 @@
>>> *
>>> * @param name the name of the bean
>>> * @param clazz the class of the bean
>>> + * @return the bean metadata
>>> */
>>> protected BeanMetaData createWeldEnabledBeanMetaData(String name, Class<?> clazz)
>>> {
>>> @@ -228,9 +230,13 @@
>>>
>>> /**
>>> * Gets a weld instance that has been
>>> + *
>>> + * @param <T> the type
>>> * @param clazz the class we want to get an instance of
>>> * @return the instance
>>> + * @throws Exception for any error
>>> */
>>> + @SuppressWarnings("unchecked")
>>> protected <T> T getWeldBean(Class<T> clazz) throws Exception
>>> {
>>> Set<Bean<?>> beans = getCurrentManager().getBeans(clazz);
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/WeldMcTestDelegate.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/WeldMcTestDelegate.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/WeldMcTestDelegate.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -68,6 +68,7 @@
>>> * Constructor
>>> *
>>> * @param clazz the test class
>>> + * @throws Exception for any error
>>> */
>>> protected WeldMcTestDelegate(Class<?> clazz) throws Exception
>>> {
>>>
>>> Modified: projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/annotated/test/AnnotatedTypeTestCase.java
>>> ===================================================================
>>> --- projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/annotated/test/AnnotatedTypeTestCase.java 2009-11-19 13:46:19 UTC (rev 96566)
>>> +++ projects/kernel/trunk/weld-int/src/test/java/org/jboss/test/kernel/weld/annotated/test/AnnotatedTypeTestCase.java 2009-11-19 13:46:21 UTC (rev 96567)
>>> @@ -99,6 +99,7 @@
>>> checkNotAnnotatedNoAnnotations(type);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testNoAnnotationsOnClassWithMetaData() throws Exception
>>> {
>>> MetaData metaData = createMetaDataWithAnnotations(NotAnnotatedBean.class);
>>> @@ -155,6 +156,7 @@
>>> checkAnnotatedBeanNoMetaData(type);
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testAnnotationsOnClassWithMetaData() throws Exception
>>> {
>>> MetaData metaData = createMetaDataWithAnnotations(AnnotatedBean.class);
>>> @@ -224,6 +226,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> public void testInheritance() throws Exception
>>> {
>>> AnnotatedType<Child> type = getCurrentManager().createAnnotatedType(Child.class);
>>> @@ -312,6 +315,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> private void checkAnnotationsOnParentClass(AnnotatedType<? super Child> type)
>>> {
>>> assertEquals(Parent.class, type.getJavaClass());
>>> @@ -360,6 +364,7 @@
>>> }
>>> }
>>>
>>> + @SuppressWarnings("unchecked")
>>> private void checkAnnotatedBeanNoMetaData(AnnotatedType<?> type)
>>> {
>>> assertAnnotations(type, "XXX", Test1.class, Test3.class);
>>>
>>> _______________________________________________
>>> jboss-cvs-commits mailing list
>>> jboss-cvs-commits at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jboss-cvs-commits
>>
> --
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Adrian Brock
> Chief Scientist
> JBoss by Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
More information about the jboss-cvs-commits
mailing list