[jboss-cvs] JBossAS SVN: r97151 - projects/embedded/trunk/api/src/main/java/org/jboss/embedded/api/server.

[jboss-cvs-commits at lists.jboss.org]

Author: ALRubinger
Date: 2009-11-30 01:45:05 -0500 (Mon, 30 Nov 2009)
New Revision: 97151

Modified:
   projects/embedded/trunk/api/src/main/java/org/jboss/embedded/api/server/JBossHomeClassLoader.java
Log:
[EMB-73] Some cleanup, preconditions, and reduced visibility of nonpublic members

Modified: projects/embedded/trunk/api/src/main/java/org/jboss/embedded/api/server/JBossHomeClassLoader.java
===================================================================
--- projects/embedded/trunk/api/src/main/java/org/jboss/embedded/api/server/JBossHomeClassLoader.java	2009-11-30 05:42:18 UTC (rev 97150)
+++ projects/embedded/trunk/api/src/main/java/org/jboss/embedded/api/server/JBossHomeClassLoader.java	2009-11-30 06:45:05 UTC (rev 97151)
@@ -59,7 +59,7 @@
     * pruned list in order to not leak out class references, which would
     * in turn result in {@link NoClassDefFoundError}
     */
-   public static final String[] JBOSS_LIB_BOOT_LIST =
+   private static final String[] JBOSS_LIB_BOOT_LIST =
    {
          // Concurrent
          "concurrent.jar",
@@ -89,16 +89,6 @@
          // Fixme aop
          "jboss-aop.jar", "jboss-aop-mc-int.jar", "trove.jar"};
 
-   /**
-    * Libraries, relative to $JBOSS_HOME/bin, which must be visible to 
-    * the context ClassLoader (and the loading CL of the server)
-    * in order to boot the Application Server.  This is a carefully
-    * pruned list in order to not leak out class references, which would
-    * in turn result in {@link NoClassDefFoundError}
-    */
-   public static final String[] JBOSS_BIN_BOOT_LIST =
-   {"run.jar"};
-
    //-------------------------------------------------------------------------------------||
    // Constructor ------------------------------------------------------------------------||
    //-------------------------------------------------------------------------------------||
@@ -125,9 +115,16 @@
     * @param jbossHome The location to JBOSS_HOME
     * @param urls Additional URLs which this ClassLoader should use; may be null
     * @param parent The parent to assign to the new ClassLoader
+    * @throws IllegalArgumentException If JBOSS_HOME is not specified
     */
    public static JBossHomeClassLoader newInstance(final URL jbossHome, final URL[] urls, final ClassLoader parent)
    {
+      // Precondition checks
+      if (jbossHome == null)
+      {
+         throw new IllegalArgumentException("JBOSS_HOME must be specified");
+      }
+
       // Get $JBOSS_HOME/lib URLs
       final URL[] jbossLibBootUrls = getJBossLibBootUrls(jbossHome);