[jboss-cvs] JBossAS SVN: r97165 - in projects/jboss-jca/trunk: fungal/src/main/java/org/jboss/jca/fungal/deployers and 2 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: jesper.pedersen
Date: 2009-11-30 09:34:34 -0500 (Mon, 30 Nov 2009)
New Revision: 97165

Modified:
   projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployer.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployers/CloneableDeployer.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/DeploymentDeployer.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/MainDeployerImpl.java
   projects/jboss-jca/trunk/tools/findbugs/filter.xml
Log:
findbugs fixes

Modified: projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployer.java
===================================================================
--- projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployer.java	2009-11-30 14:26:19 UTC (rev 97164)
+++ projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployer.java	2009-11-30 14:34:34 UTC (rev 97165)
@@ -62,7 +62,7 @@
  * @author <a href="mailto:jesper.pedersen at jboss.org">Jesper Pedersen</a>
  * @author <a href="mailto:jeff.zhang at jboss.org">Jeff Zhang</a>
  */
-public class RADeployer implements CloneableDeployer
+public final class RADeployer implements CloneableDeployer
 {
    private static Logger log = Logger.getLogger(RADeployer.class);
    private static boolean trace = log.isTraceEnabled();

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployers/CloneableDeployer.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployers/CloneableDeployer.java	2009-11-30 14:26:19 UTC (rev 97164)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployers/CloneableDeployer.java	2009-11-30 14:34:34 UTC (rev 97165)
@@ -26,7 +26,7 @@
  * The deployer interface for JCA/Fungal
  * @author <a href="mailto:jesper.pedersen at jboss.org">Jesper Pedersen</a>
  */
-public interface CloneableDeployer extends Deployer
+public interface CloneableDeployer extends Cloneable, Deployer
 {
    /**
     * Clone the deployer

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/DeploymentDeployer.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/DeploymentDeployer.java	2009-11-30 14:26:19 UTC (rev 97164)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/DeploymentDeployer.java	2009-11-30 14:34:34 UTC (rev 97165)
@@ -51,7 +51,7 @@
  * The deployment deployer (deploys .xml files)
  * @author <a href="mailto:jesper.pedersen at jboss.org">Jesper Pedersen</a>
  */
-public class DeploymentDeployer implements CloneableDeployer
+public final class DeploymentDeployer implements CloneableDeployer
 {
    /** The kernel */
    private KernelImpl kernel;

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/MainDeployerImpl.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/MainDeployerImpl.java	2009-11-30 14:26:19 UTC (rev 97164)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/MainDeployerImpl.java	2009-11-30 14:34:34 UTC (rev 97165)
@@ -35,7 +35,7 @@
  * The main deployer for JBoss JCA/Fungal
  * @author <a href="mailto:jesper.pedersen at jboss.org">Jesper Pedersen</a>
  */
-public class MainDeployerImpl implements Cloneable, MainDeployerImplMBean
+public final class MainDeployerImpl implements Cloneable, MainDeployerImplMBean
 {
    private static List<Deployer> deployers = new CopyOnWriteArrayList<Deployer>();
 

Modified: projects/jboss-jca/trunk/tools/findbugs/filter.xml
===================================================================
--- projects/jboss-jca/trunk/tools/findbugs/filter.xml	2009-11-30 14:26:19 UTC (rev 97164)
+++ projects/jboss-jca/trunk/tools/findbugs/filter.xml	2009-11-30 14:34:34 UTC (rev 97165)
@@ -80,6 +80,10 @@
 
   <!--  org.jboss.jca.web filter -->
   <Match>
+    <Class name="org.jboss.jca.web.WARDeployer"/>
+    <Bug code="IS"/>
+  </Match>
+  <Match>
     <Class name="org.jboss.jca.web.WARDeployment"/>
     <Bug code="UrF"/>
   </Match>