[jboss-cvs] JBossAS SVN: r94984 - in projects/jboss-jca/trunk: core/src/main/java/org/jboss/jca/core/connectionmanager and 10 other directories.

jboss-cvs-commits at lists.jboss.org jboss-cvs-commits at lists.jboss.org
Thu Oct 15 15:13:59 EDT 2009


Author: jesper.pedersen
Date: 2009-10-15 15:13:59 -0400 (Thu, 15 Oct 2009)
New Revision: 94984

Modified:
   projects/jboss-jca/trunk/build.xml
   projects/jboss-jca/trunk/core/src/main/java/org/jboss/jca/core/connectionmanager/ConnectionManagerImpl.java
   projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployment.java
   projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/mc/hack/MainScanner.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/bootstrap/Bootstrap.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/BeanType.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/ConstructorType.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/Deployment.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/PropertyType.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/BeanDeployment.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/DeploymentDeployer.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/KernelImpl.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/util/FileUtil.java
   projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/util/Injection.java
   projects/jboss-jca/trunk/standalone/src/main/java/org/jboss/jca/standalone/Main.java
   projects/jboss-jca/trunk/standalone/src/main/java/org/jboss/jca/standalone/hack/JMX.java
   projects/jboss-jca/trunk/standalone/src/main/resources/bootstrap/transaction.xml
   projects/jboss-jca/trunk/tools/findbugs/filter.xml
Log:
[JBJCA-196] Set Findbugs report level to low

Modified: projects/jboss-jca/trunk/build.xml
===================================================================
--- projects/jboss-jca/trunk/build.xml	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/build.xml	2009-10-15 19:13:59 UTC (rev 94984)
@@ -344,7 +344,8 @@
     <findbugs home="${basedir}/tools/findbugs/lib/"
               output="html"
               outputFile="${reports.dir}/findbugs/findbugs.html" 
-              excludeFilter="${basedir}/tools/findbugs/filter.xml">
+              excludeFilter="${basedir}/tools/findbugs/filter.xml"
+              reportLevel="low">
       <auxClasspath>
         <fileset dir="${lib.dir}/standalone">
           <include name="*.jar"/>
@@ -368,7 +369,8 @@
     <findbugs home="${basedir}/tools/findbugs/lib/"
               output="xml:withMessages"
               outputFile="${reports.dir}/findbugs/findbugs.xml" 
-              excludeFilter="${basedir}/tools/findbugs/filter.xml">
+              excludeFilter="${basedir}/tools/findbugs/filter.xml"
+              reportLevel="low">
       <auxClasspath>
         <fileset dir="${lib.dir}/standalone">
           <include name="*.jar"/>

Modified: projects/jboss-jca/trunk/core/src/main/java/org/jboss/jca/core/connectionmanager/ConnectionManagerImpl.java
===================================================================
--- projects/jboss-jca/trunk/core/src/main/java/org/jboss/jca/core/connectionmanager/ConnectionManagerImpl.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/core/src/main/java/org/jboss/jca/core/connectionmanager/ConnectionManagerImpl.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -46,7 +46,7 @@
     */
    public ConnectionManagerImpl()
    {
-      
+      this.realConnectionManager = null;
    }
    
    /**

Modified: projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployment.java
===================================================================
--- projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployment.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployment.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -37,7 +37,6 @@
 public class RADeployment implements Deployment
 {
    private static Logger log = Logger.getLogger(RADeployer.class);
-   private static boolean trace = log.isTraceEnabled();
 
    /** The resource adapter file */
    private URL adapter;

Modified: projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/mc/hack/MainScanner.java
===================================================================
--- projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/mc/hack/MainScanner.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/mc/hack/MainScanner.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -187,6 +187,6 @@
          log.info("Deploying " + deployment.getName());
          deployments.add(deployment);
       }
-      mainDeployer.deploy(deployments.toArray(new Deployment[0]));
+      mainDeployer.deploy(deployments.toArray(new Deployment[deployments.size()]));
    }
 }

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/bootstrap/Bootstrap.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/bootstrap/Bootstrap.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/bootstrap/Bootstrap.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -47,7 +47,7 @@
    public List<String> getUrl()
    {
       if (url == null) 
-         url = new ArrayList<String>();
+         url = new ArrayList<String>(1);
       
       return url;
    }

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/BeanType.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/BeanType.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/BeanType.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -75,7 +75,7 @@
    public List<PropertyType> getProperty()
    {
       if (property == null)
-         property = new ArrayList<PropertyType>();
+         property = new ArrayList<PropertyType>(1);
 
       return property;
    }
@@ -87,7 +87,7 @@
    public List<DependsType> getDepends()
    {
       if (depends == null)
-         depends = new ArrayList<DependsType>();
+         depends = new ArrayList<DependsType>(1);
 
       return depends;
    }

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/ConstructorType.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/ConstructorType.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/ConstructorType.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -52,7 +52,7 @@
    public List<ParameterType> getParameter()
    {
       if (parameter == null)
-         parameter = new ArrayList<ParameterType>();
+         parameter = new ArrayList<ParameterType>(1);
 
       return parameter;
    }

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/Deployment.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/Deployment.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/Deployment.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -47,7 +47,7 @@
    public List<BeanType> getBean()
    {
       if (bean == null)
-         bean = new ArrayList<BeanType>();
+         bean = new ArrayList<BeanType>(1);
 
       return bean;
    }

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/PropertyType.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/PropertyType.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/deployment/PropertyType.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -51,7 +51,7 @@
    public List<Object> getContent()
    {
       if (content == null)
-         content = new ArrayList<Object>();
+         content = new ArrayList<Object>(1);
       
       return this.content;
    }

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/BeanDeployment.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/BeanDeployment.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/BeanDeployment.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -24,6 +24,7 @@
 
 import org.jboss.jca.fungal.deployers.Deployment;
 
+import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.net.URL;
 import java.util.Collections;
@@ -108,8 +109,9 @@
 
    /**
     * Destroy
+    * @exception Throwable If the unit cant be stopped
     */
-   public void destroy()
+   public void destroy() throws Throwable
    {
       List<String> shutdownBeans = new LinkedList<String>(beans);
       Collections.reverse(shutdownBeans);
@@ -125,20 +127,28 @@
             Method stopMethod = bean.getClass().getMethod("stop", (Class[])null);
             stopMethod.invoke(bean, (Object[])null);
          }
-         catch (Exception e)
+         catch (NoSuchMethodException nsme)
          {
-            // No stop method
+            // No create method
          }
+         catch (InvocationTargetException ite)
+         {
+            throw ite.getTargetException();
+         }
 
          try
          {
             Method destroyMethod = bean.getClass().getMethod("destroy", (Class[])null);
             destroyMethod.invoke(bean, (Object[])null);
          }
-         catch (Exception e)
+         catch (NoSuchMethodException nsme)
          {
-            // No destroy method
+            // No create method
          }
+         catch (InvocationTargetException ite)
+         {
+            throw ite.getTargetException();
+         }
 
          kernel.removeBean(name);
       }

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/DeploymentDeployer.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/DeploymentDeployer.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/DeploymentDeployer.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -41,6 +41,7 @@
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.Future;
@@ -224,7 +225,7 @@
          Set<String> result = null;
 
          List<DependsType> dts = bt.getDepends();
-         if (dts != null)
+         if (dts.size() > 0)
          {
             result = new HashSet<String>();
             for (DependsType dt : dts)
@@ -234,7 +235,7 @@
          }
 
          List<PropertyType> pts = bt.getProperty();
-         if (pts != null)
+         if (pts.size() > 0)
          {
             if (result == null)
                result = new HashSet<String>();
@@ -302,7 +303,7 @@
             Method factoryMethod = null;
             Object[] args = null;
 
-            if (ct.getParameter() == null)
+            if (ct.getParameter().size() == 0)
             {
                factoryMethod = factoryClass.getMethod(ct.getFactoryMethod(), (Class[])null);
             }
@@ -492,7 +493,7 @@
        */
       private void setBeanProperty(Object instance, PropertyType pt, ClassLoader cl) throws Exception
       {
-         String name = "set" + pt.getName().substring(0, 1).toUpperCase() + pt.getName().substring(1);
+         String name = "set" + pt.getName().substring(0, 1).toUpperCase(Locale.US) + pt.getName().substring(1);
          Method m = null;
       
          if (pt.getClazz() == null)
@@ -546,13 +547,13 @@
                try
                {
                   String getMethodName = "get" + 
-                     it.getProperty().substring(0, 1).toUpperCase() + it.getProperty().substring(1);
+                     it.getProperty().substring(0, 1).toUpperCase(Locale.US) + it.getProperty().substring(1);
                   method = injectionObject.getClass().getMethod(getMethodName, (Class[])null);
                }
                catch (NoSuchMethodException nsme)
                {
                   String isMethodName = "is" + 
-                     it.getProperty().substring(0, 1).toUpperCase() + it.getProperty().substring(1);
+                     it.getProperty().substring(0, 1).toUpperCase(Locale.US) + it.getProperty().substring(1);
                   method = injectionObject.getClass().getMethod(isMethodName, (Class[])null);
                }
 

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/KernelImpl.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/KernelImpl.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/impl/KernelImpl.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -541,7 +541,7 @@
 
          if (jars != null)
          {
-            for (int j = 0; jars != null && j < jars.length; j++)
+            for (int j = 0; j < jars.length; j++)
             {
                list.add(jars[j].getCanonicalFile().toURI().toURL());
             }
@@ -550,7 +550,7 @@
          return list.toArray(new URL[list.size()]);      
       }
 
-      return null;
+      return new URL[0];
    }
 
    /**
@@ -578,7 +578,7 @@
          return list.toArray(new URL[list.size()]);      
       }
 
-      return null;
+      return new URL[0];
    }
 
    /**

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/util/FileUtil.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/util/FileUtil.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/util/FileUtil.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -77,9 +77,24 @@
       File manifestFile = new File(directory, "META-INF/MANIFEST.MF");
       if (manifestFile.exists())
       {
-         FileInputStream fis = new FileInputStream(manifestFile);
-         manifest = new Manifest(fis);
-         fis.close();
+         FileInputStream fis = null;
+         try
+         {
+            fis = new FileInputStream(manifestFile);
+            manifest = new Manifest(fis);
+         }
+         finally
+         {
+            try
+            {
+               if (fis != null)
+                  fis.close();
+            }
+            catch (IOException ignore)
+            {
+               // Ignore
+            }
+         }
       }
       else
       {
@@ -87,50 +102,66 @@
          manifest = new Manifest();
       }
 
-      FileOutputStream fos = new FileOutputStream(target);
-      JarOutputStream jos = new JarOutputStream(fos, manifest);
+      JarOutputStream jos = null;
 
-      int bytesRead;
-      byte[] buffer = new byte[4096];
+      try
+      {
+         FileOutputStream fos = new FileOutputStream(target);
+         jos = new JarOutputStream(fos, manifest);
 
-      List<File> entries = findEntries(directory);
+         int bytesRead;
+         byte[] buffer = new byte[4096];
 
-      if (entries != null)
-      {
-         entries.remove(new File("META-INF/MANIFEST.MF"));
+         List<File> entries = findEntries(directory);
 
-         for (File file : entries)
+         if (entries != null)
          {
-            File f = new File(directory, file.getPath());
-            JarEntry entry = new JarEntry(file.getPath());
-            jos.putNextEntry(entry);
+            entries.remove(new File("META-INF/MANIFEST.MF"));
 
-            FileInputStream in = null;
-            try
+            for (File file : entries)
             {
-               in = new FileInputStream(f);
-               while ((bytesRead = in.read(buffer)) != -1)
-                  jos.write(buffer, 0, bytesRead);
-            }
-            finally
-            {
-               if (in != null)
+               File f = new File(directory, file.getPath());
+               JarEntry entry = new JarEntry(file.getPath());
+               jos.putNextEntry(entry);
+
+               FileInputStream in = null;
+               try
                {
-                  try
+                  in = new FileInputStream(f);
+                  while ((bytesRead = in.read(buffer)) != -1)
+                     jos.write(buffer, 0, bytesRead);
+               }
+               finally
+               {
+                  if (in != null)
                   {
-                     in.close(); 
+                     try
+                     {
+                        in.close(); 
+                     }
+                     catch (IOException ioe)
+                     {
+                        // Ignore
+                     }
                   }
-                  catch (IOException ioe)
-                  {
-                     // Ignore
-                  }
                }
             }
          }
+
+         jos.flush();
       }
-
-      jos.flush();
-      jos.close();
+      finally
+      {
+         try
+         {
+            if (jos != null)
+               jos.close();
+         }
+         catch (IOException ignore)
+         {
+            // Ignore
+         }
+      }
    }
 
    /**
@@ -166,21 +197,47 @@
 
          if (!je.isDirectory())
          {
-            InputStream in = new BufferedInputStream(jar.getInputStream(je));
-            OutputStream out = new BufferedOutputStream(new FileOutputStream(copy));
+            InputStream in = null;
+            OutputStream out = null;
 
-            byte[] buffer = new byte[4096];
-            for (;;)
+            try
             {
-               int nBytes = in.read(buffer);
-               if (nBytes <= 0)
-                  break;
+               in = new BufferedInputStream(jar.getInputStream(je));
+               out = new BufferedOutputStream(new FileOutputStream(copy));
 
-               out.write(buffer, 0, nBytes);
+               byte[] buffer = new byte[4096];
+               for (;;)
+               {
+                  int nBytes = in.read(buffer);
+                  if (nBytes <= 0)
+                     break;
+
+                  out.write(buffer, 0, nBytes);
+               }
+               out.flush();
             }
-            out.flush();
-            out.close();
-            in.close();
+            finally
+            {
+               try
+               {
+                  if (out != null)
+                     out.close();
+               }
+               catch (IOException ignore)
+               {
+                  // Ignore
+               }
+
+               try
+               {
+                  if (in != null)
+                     in.close();
+               }
+               catch (IOException ignore)
+               {
+                  // Ignore
+               }
+            }
          }
          else
          {

Modified: projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/util/Injection.java
===================================================================
--- projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/util/Injection.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/fungal/src/main/java/org/jboss/jca/fungal/util/Injection.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -24,6 +24,7 @@
 
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
+import java.util.Locale;
 
 /**
  * Injection utility
@@ -112,7 +113,7 @@
                                             "property " + propertyName);
       }
 
-      String methodName = "set" + propertyName.substring(0, 1).toUpperCase();
+      String methodName = "set" + propertyName.substring(0, 1).toUpperCase(Locale.US);
       if (propertyName.length() > 1)
       {
          methodName += propertyName.substring(1);

Modified: projects/jboss-jca/trunk/standalone/src/main/java/org/jboss/jca/standalone/Main.java
===================================================================
--- projects/jboss-jca/trunk/standalone/src/main/java/org/jboss/jca/standalone/Main.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/standalone/src/main/java/org/jboss/jca/standalone/Main.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -28,6 +28,7 @@
 import java.lang.management.MemoryMXBean;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Field;
+import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.net.MalformedURLException;
 import java.net.URI;
@@ -173,10 +174,18 @@
             serverMethodShutdown.invoke(server);
          }
       }
-      catch (Exception e)
+      catch (NoSuchMethodException nsme)
       {
-         e.printStackTrace(System.err);
+         // Ignore
       }
+      catch (IllegalAccessException iae)
+      {
+         iae.printStackTrace(System.err);
+      }
+      catch (InvocationTargetException ite)
+      {
+         ite.printStackTrace(System.err);
+      }
    }
 
    /**

Modified: projects/jboss-jca/trunk/standalone/src/main/java/org/jboss/jca/standalone/hack/JMX.java
===================================================================
--- projects/jboss-jca/trunk/standalone/src/main/java/org/jboss/jca/standalone/hack/JMX.java	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/standalone/src/main/java/org/jboss/jca/standalone/hack/JMX.java	2009-10-15 19:13:59 UTC (rev 94984)
@@ -59,7 +59,7 @@
     * Get the MBeanServer
     * @return The MBeanServer
     */
-   public MBeanServer getMbeanServer()
+   public MBeanServer getMBeanServer()
    {
       return mbeanServer;
    }

Modified: projects/jboss-jca/trunk/standalone/src/main/resources/bootstrap/transaction.xml
===================================================================
--- projects/jboss-jca/trunk/standalone/src/main/resources/bootstrap/transaction.xml	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/standalone/src/main/resources/bootstrap/transaction.xml	2009-10-15 19:13:59 UTC (rev 94984)
@@ -13,7 +13,7 @@
 <!--    <annotation>@org.jboss.aop.microcontainer.aspects.jmx.JMX(name="jboss:service=TransactionManager", exposedInterface=com.arjuna.ats.jbossatx.jta.TransactionManagerServiceMBean.class, registerDirectly=true)</annotation> -->
     <property name="transactionTimeout">300</property>
     <property name="objectStoreDir">${jboss.jca.home}/server/jca/tmp/tx-object-store</property>
-    <property name="mbeanServer"><inject bean="JMX" property="mbeanServer"/></property>
+    <property name="mbeanServer"><inject bean="JMX" property="MBeanServer"/></property>
     <property name="transactionStatusManagerInetAddress">localhost</property>
     <property name="transactionStatusManagerPort">4713</property>
     <property name="recoveryInetAddress">localhost</property>

Modified: projects/jboss-jca/trunk/tools/findbugs/filter.xml
===================================================================
--- projects/jboss-jca/trunk/tools/findbugs/filter.xml	2009-10-15 18:46:35 UTC (rev 94983)
+++ projects/jboss-jca/trunk/tools/findbugs/filter.xml	2009-10-15 19:13:59 UTC (rev 94984)
@@ -11,12 +11,16 @@
   </Match>
   <Match>
     <Class name="javax.resource.spi.InvalidPropertyException"/>
-    <Bug code="EI,EI2"/>
+    <Bug code="EI,EI2,Se"/>
   </Match>
   <Match>
     <Class name="javax.resource.spi.security.PasswordCredential"/>
     <Bug code="EI"/>
   </Match>
+  <Match>
+    <Class name="javax.resource.spi.work.HintsContext"/>
+    <Bug code="Se"/>
+  </Match>
 
   <!--  org.jboss.jca.common filter -->
   <Match>
@@ -34,17 +38,36 @@
     <Bug code="Nm"/>
   </Match>
 
+  <!--  org.jboss.jca.deployers filter -->
+  <Match>
+    <Class name="org.jboss.jca.deployers.fungal.RADeployer"/>
+    <Bug code="DLS"/>
+  </Match>
+
+  <!--  org.jboss.jca.fungal filter -->
+  <Match>
+    <Class name="org.jboss.jca.fungal.impl.DeploymentDeployer"/>
+    <Bug code="DLS,UPM"/>
+  </Match>
+  <Match>
+    <Class name="org.jboss.jca.fungal.impl.KernelImpl"/>
+    <Bug code="UPM"/>
+  </Match>
+
   <!--  org.jboss.jca.sjc filter -->
   <Match>
-    <Class name="org.jboss.jca.sjc.Main$LifeThread"/>
-    <Bug code="UW"/>
+    <Class name="org.jboss.jca.sjc.Main"/>
+    <Bug code="UPM"/>
   </Match>
   <Match>
     <Class name="org.jboss.jca.sjc.Main$LifeThread"/>
-    <Bug code="Wa"/>
+    <Bug code="UW,Wa"/>
   </Match>
+
+  <!--  org.jboss.jca.standalone filter -->
   <Match>
-    <Class name="org.jboss.jca.sjc.deployers.ra.RADeployer"/>
-    <Bug code="DLS"/>
+    <Class name="org.jboss.jca.standalone.Main"/>
+    <Bug code="UPM"/>
   </Match>
+
 </FindBugsFilter>




More information about the jboss-cvs-commits mailing list