[jboss-cvs] jboss-cvs-commits Digest, Vol 39, Issue 290

[Ales Justin]

OK, I'll have a look and try to fix some of the stuff you broke. :-)
Hopefully I'll find some time at the end of the week or early next week.

Rémy Maucherat wrote:
> On Wed, Sep 23, 2009 at 7:25 AM, Ales Justin <ales.justin at gmail.com> wrote:
>> Why would this make it filter only war deployments?
>>
>> From the code, it will handle/check all deployments.
>> Unless I'm missing something obvious.
> 
> Well, you know, this stuff is pretty complex to me, it has no docs,
> and I'm using the other deployers as examples, etc. So it might be
> possible that I'm not doing things right. Please fix it, or suggest
> how to fix it ;)

Only handle war deployments ==> deployer's input == JBossWebMetaData
e.g. use AbstractSimpleVFSRealDeployer<JBossWebMetaData>

> Right now, I have added:
>    <bean name="ServletContainerInitializerDeployer"
> class="org.jboss.deployment.ServletContainerInitializerDeployer">
>       <property name="relativeOrder">2004</property>

Relative order should be the last resort to use.
You should use proper inputs/outputs to place the deployer at the right 
place.

>    </bean>
> to war-deployers-jboss-beans.xml in the jbossweb deployer, and it looks ok.
> 
> Another item: I broke web annotations, and I did not understand why. I
> had modified AnnotationMetaDataDeployer ;) Instead
> OptAnnotationMetaDataDeployer is being used. Woops. I don't see how to
> make AnnotationEnvironment compatible with the per JAR handling that
> is needed in Servlet 3.0, so I would need to switch back to
> AnnotationMetaDataDeployer for now in trunk. We'd switch back to the
> more optimized deployer asap.

I'll see what can be done, more info on the existing forum post.