[jboss-cvs] jboss-cvs-commits Digest, Vol 39, Issue 323

[Jason T. Greene]

I didn't add one since it just looked like a small oversight.

It's basically:

treeset.add(key);
key.mutate();

However, I suppose the problem highlights a lack of coverage, so there 
probably should be a test case. I'll add it.

Ales Justin wrote:
> What about some test for this? ;-)
> 
>> Author: jason.greene at jboss.com
>> Date: 2009-09-24 21:57:42 -0400 (Thu, 24 Sep 2009)
>> New Revision: 94013
>>
>> Modified:
>>    
>> projects/jboss-deployers/branches/Branch_2_0/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers/AbstractStructureBuilder.java 
>>
>> Log:
>> Fix JBDEPLOY-215
>>
>>
>> Modified: 
>> projects/jboss-deployers/branches/Branch_2_0/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers/AbstractStructureBuilder.java 
>>
>> ===================================================================
>> --- 
>> projects/jboss-deployers/branches/Branch_2_0/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers/AbstractStructureBuilder.java    
>> 2009-09-25 01:37:45 UTC (rev 94012)
>> +++ 
>> projects/jboss-deployers/branches/Branch_2_0/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers/AbstractStructureBuilder.java    
>> 2009-09-25 01:57:42 UTC (rev 94013)
>> @@ -135,10 +135,11 @@
>>                 if (childContext == null)
>>                    throw new IllegalStateException("Child deployment 
>> context is null");
>>  
>> -               context.addChild(childContext);
>>                 childContext.setParent(context);
>> -
>>                 applyContextInfo(childContext, child);
>> +               +               // Child must be added after context 
>> info is applied for correct sorting
>> +               context.addChild(childContext);
>>  
>>                 Attachments attachments = 
>> child.getPredeterminedManagedObjects();                 if 
>> (attachments != null)
>>
>>
>>
>> ------------------------------
>>
>> Message: 2
>> Date: Thu, 24 Sep 2009 22:02:08 -0400
>> From: jboss-cvs-commits at lists.jboss.org
>> Subject: [jboss-cvs] JBossAS SVN: r94014 -
>>     projects/jboss-deployers/trunk/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers. 
>>
>>     
>> To: jboss-cvs-commits at lists.jboss.org
>> Message-ID:
>>     <200909250202.n8P228U9010360 at svn01.web.mwc.hst.phx2.redhat.com>
>> Content-Type: text/plain; charset=UTF-8
>>
>> Author: jason.greene at jboss.com
>> Date: 2009-09-24 22:02:07 -0400 (Thu, 24 Sep 2009)
>> New Revision: 94014
>>
>> Modified:
>>    
>> projects/jboss-deployers/trunk/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers/AbstractStructureBuilder.java 
>>
>> Log:
>> Merge JBDEPLOY-215 from 94013
>>
>>
>> Modified: 
>> projects/jboss-deployers/trunk/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers/AbstractStructureBuilder.java 
>>
>> ===================================================================
>> --- 
>> projects/jboss-deployers/trunk/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers/AbstractStructureBuilder.java    
>> 2009-09-25 01:57:42 UTC (rev 94013)
>> +++ 
>> projects/jboss-deployers/trunk/deployers-structure-spi/src/main/java/org/jboss/deployers/structure/spi/helpers/AbstractStructureBuilder.java    
>> 2009-09-25 02:02:07 UTC (rev 94014)
>> @@ -135,10 +135,11 @@
>>                 if (childContext == null)
>>                    throw new IllegalStateException("Child deployment 
>> context is null");
>>  
>> -               context.addChild(childContext);
>>                 childContext.setParent(context);
>> -
>>                 applyContextInfo(childContext, child);
>> +               +               // Child must be added after context 
>> info is applied for correct sorting
>> +               context.addChild(childContext);
>>  
>>                 Attachments attachments = 
>> child.getPredeterminedManagedObjects();                 if 
>> (attachments != null)
>>


-- 
Jason T. Greene
JBoss, a division of Red Hat