[jboss-cvs] jboss-cvs-commits Digest, Vol 39, Issue 342
Jason T. Greene
jason.greene at redhat.com
Mon Sep 28 21:09:31 EDT 2009
BTW your patch breaks compilation.
Jason T. Greene wrote:
> I did. I don't understand the issue?
>
> Ales Justin wrote:
>> Could you please next time you try to test anything actually, run the
>> overall tests?
>> If not, I would prefer if you don't commit your stuff at all.
>>
>> Thanks.
>>
>> -Ales
>>
>>
>> ------------------------------
>>
>> Message: 8
>> Date: Mon, 28 Sep 2009 07:25:58 -0400
>> From: jboss-cvs-commits at lists.jboss.org
>> <mailto:jboss-cvs-commits at lists.jboss.org>
>> Subject: [jboss-cvs] JBossAS SVN: r94057 - in
>> projects/jboss-deployers/trunk:
>>
>> deployers-vfs/src/test/java/org/jboss/test/deployers/vfs/structurebuilder/test
>>
>> and 2 other directories.
>> To: jboss-cvs-commits at lists.jboss.org
>> <mailto:jboss-cvs-commits at lists.jboss.org>
>> Message-ID:
>>
>> <200909281125.n8SBPwXw026610 at svn01.web.mwc.hst.phx2.redhat.com
>>
>> <mailto:200909281125.n8SBPwXw026610 at svn01.web.mwc.hst.phx2.redhat.com>>
>> Content-Type: text/plain; charset=UTF-8
>>
>> Author: alesj
>> Date: 2009-09-28 07:25:58 -0400 (Mon, 28 Sep 2009)
>> New Revision: 94057
>>
>> Added:
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/
>>
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child1
>>
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child2
>>
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child3
>>
>> Modified:
>>
>> projects/jboss-deployers/trunk/deployers-structure-spi/src/test/java/org/jboss/test/deployers/structure/structurebuilder/AbstractStructureBuilderTest.java
>>
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/java/org/jboss/test/deployers/vfs/structurebuilder/test/FilesStructureBuilderUnitTestCase.java
>>
>> Log:
>> Fix Jason's bad (non-tested) tests.
>>
>> Modified:
>>
>> projects/jboss-deployers/trunk/deployers-structure-spi/src/test/java/org/jboss/test/deployers/structure/structurebuilder/AbstractStructureBuilderTest.java
>>
>> ===================================================================
>> ---
>>
>> projects/jboss-deployers/trunk/deployers-structure-spi/src/test/java/org/jboss/test/deployers/structure/structurebuilder/AbstractStructureBuilderTest.java
>>
>> 2009-09-28 11:06:46 UTC (rev 94056)
>> +++
>>
>> projects/jboss-deployers/trunk/deployers-structure-spi/src/test/java/org/jboss/test/deployers/structure/structurebuilder/AbstractStructureBuilderTest.java
>>
>> 2009-09-28 11:25:58 UTC (rev 94057)
>> @@ -23,6 +23,7 @@
>>
>> import java.util.List;
>> import java.util.Map;
>> +import java.util.Random;
>>
>> import org.jboss.deployers.client.spi.Deployment;
>> import org.jboss.deployers.client.spi.DeploymentFactory;
>> @@ -135,25 +136,33 @@
>> return deployment;
>> }
>>
>> - protected Deployment createOrderedChildren() throws Exception
>> + protected Deployment createOrderedChildren(String... names)
>> throws Exception
>> {
>> DeploymentFactory factory = getDeploymentFactory();
>> Deployment deployment = createDeployment(factory);
>> - ContextInfo ctx = factory.addContext(deployment, "child1");
>> - ctx.setRelativeOrder(1);
>> - ctx = factory.addContext(deployment, "child2");
>> - ctx.setRelativeOrder(2);
>> -
>> + for (int i = 0; names != null && i < names.length; i++)
>> + {
>> + ContextInfo ctx = factory.addContext(deployment, "child" +
>> names[i]);
>> + ctx.setRelativeOrder(i + 1);
>> + }
>> return deployment;
>> }
>>
>> public void testOrderedChildren() throws Exception
>> {
>> - Deployment deployment = createOrderedChildren();
>> + String[] names = new String[]{"123", "132", "213", "231",
>> "312", "321"};
>> + String random = names[new Random().nextInt(6)];
>> + log.info <http://log.info>("Random: " + random);
>> + names = new String[]{String.valueOf(random.charAt(0)),
>> String.valueOf(random.charAt(1)), String.valueOf(random.charAt(2))};
>> +
>> + Deployment deployment = createOrderedChildren(names);
>> DeploymentContext context = build(deployment);
>> - assertEquals("child1",
>> context.getChildren().get(0).getRelativePath());
>> - assertEquals("child2",
>> context.getChildren().get(1).getRelativePath());
>>
>> + for (int i = 0; i < names.length; i++)
>> + {
>> + assertEquals("child" + names[i],
>> context.getChildren().get(i).getRelativePath());
>> + }
>> +
>> checkDeployment(context, deployment);
>> }
>>
>>
>> Modified:
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/java/org/jboss/test/deployers/vfs/structurebuilder/test/FilesStructureBuilderUnitTestCase.java
>>
>> ===================================================================
>> ---
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/java/org/jboss/test/deployers/vfs/structurebuilder/test/FilesStructureBuilderUnitTestCase.java
>>
>> 2009-09-28 11:06:46 UTC (rev 94056)
>> +++
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/java/org/jboss/test/deployers/vfs/structurebuilder/test/FilesStructureBuilderUnitTestCase.java
>>
>> 2009-09-28 11:25:58 UTC (rev 94057)
>> @@ -113,4 +113,10 @@
>> {
>> return createDefaultDeployment();
>> }
>> +
>> + @Override
>> + public void testOrderedChildren() throws Exception
>> + {
>> + // ignore this test
>> + }
>> }
>>
>> Copied:
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child1
>>
>> (from rev 94053,
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testManyChildren/child1)
>>
>> ===================================================================
>> ---
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child1
>>
>> (rev 0)
>> +++
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child1
>>
>> 2009-09-28 11:25:58 UTC (rev 94057)
>> @@ -0,0 +1 @@
>> +empty
>> \ No newline at end of file
>>
>> Copied:
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child2
>>
>> (from rev 94053,
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testManyChildren/child2)
>>
>> ===================================================================
>> ---
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child2
>>
>> (rev 0)
>> +++
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child2
>>
>> 2009-09-28 11:25:58 UTC (rev 94057)
>> @@ -0,0 +1 @@
>> +empty
>> \ No newline at end of file
>>
>> Copied:
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child3
>>
>> (from rev 94053,
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testManyChildren/child3)
>>
>> ===================================================================
>> ---
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child3
>>
>> (rev 0)
>> +++
>>
>> projects/jboss-deployers/trunk/deployers-vfs/src/test/resources/structurebuilder/predetermined/testOrderedChildren/child3
>>
>> 2009-09-28 11:25:58 UTC (rev 94057)
>> @@ -0,0 +1 @@
>> +empty
>> \ No newline at end of file
>>
>>
>>
>> ------------------------------
>>
>> _______________________________________________
>> jboss-cvs-commits mailing list
>> jboss-cvs-commits at lists.jboss.org
>> <mailto:jboss-cvs-commits at lists.jboss.org>
>> https://lists.jboss.org/mailman/listinfo/jboss-cvs-commits
>>
>>
>> End of jboss-cvs-commits Digest, Vol 39, Issue 342
>> **************************************************
>>
>>
>
>
--
Jason T. Greene
JBoss, a division of Red Hat
More information about the jboss-cvs-commits
mailing list