[jboss-cvs] JBossAS SVN: r104274 - in projects/jboss-reflect/trunk/src: main/java/org/jboss/reflect/plugins/javassist and 1 other directories.
jboss-cvs-commits at lists.jboss.org
jboss-cvs-commits at lists.jboss.org
Tue Apr 27 13:36:58 EDT 2010
Author: kabir.khan at jboss.com
Date: 2010-04-27 13:36:57 -0400 (Tue, 27 Apr 2010)
New Revision: 104274
Modified:
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/introspection/IntrospectionTypeInfoFactoryImpl.java
projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java
projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistConstructorInfoTestCase.java
projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistFieldInfoTestCase.java
projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistMutableMethodInfoTestCase.java
projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistMutableTypeInfoTestCase.java
Log:
[JBREFLECT-5] Make Introspection-/JavassistTypeInfoFactoryImpl constructors package protected, all access should be via Introspection-/JavassistTypeInfoFactory
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/introspection/IntrospectionTypeInfoFactoryImpl.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/introspection/IntrospectionTypeInfoFactoryImpl.java 2010-04-27 17:32:44 UTC (rev 104273)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/introspection/IntrospectionTypeInfoFactoryImpl.java 2010-04-27 17:36:57 UTC (rev 104274)
@@ -70,6 +70,10 @@
{
final static AnnotationValue[] NO_ANNOTATIONS = new AnnotationValue[0];
+ IntrospectionTypeInfoFactoryImpl()
+ {
+ }
+
/**
* Generate the type info for a class
*
Modified: projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java
===================================================================
--- projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java 2010-04-27 17:32:44 UTC (rev 104273)
+++ projects/jboss-reflect/trunk/src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java 2010-04-27 17:36:57 UTC (rev 104274)
@@ -84,6 +84,10 @@
{
private static ClassPoolFactory poolFactory = DefaultClassPoolFactory.getInstance();
+ JavassistTypeInfoFactoryImpl()
+ {
+ }
+
public static ClassPoolFactory getPoolFactory()
{
return poolFactory;
Modified: projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistConstructorInfoTestCase.java
===================================================================
--- projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistConstructorInfoTestCase.java 2010-04-27 17:32:44 UTC (rev 104273)
+++ projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistConstructorInfoTestCase.java 2010-04-27 17:36:57 UTC (rev 104274)
@@ -2,7 +2,7 @@
import junit.framework.Test;
-import org.jboss.reflect.plugins.javassist.JavassistTypeInfoFactoryImpl;
+import org.jboss.reflect.plugins.javassist.JavassistTypeInfoFactory;
import org.jboss.reflect.spi.ModifierInfo;
import org.jboss.reflect.spi.MutableClassInfo;
import org.jboss.reflect.spi.MutableConstructorInfo;
@@ -23,7 +23,7 @@
public void testAddConstructor()
{
- MutableClassInfo mci = new JavassistTypeInfoFactoryImpl().getMutable("org.jboss.test.plugins.javassist.support.PojoConstructor", null);
+ MutableClassInfo mci = new JavassistTypeInfoFactory().getMutable("org.jboss.test.plugins.javassist.support.PojoConstructor", null);
try
{
MutableConstructorInfo intConstructor = mci.getDeclaredConstructor("int");
@@ -41,7 +41,7 @@
public void testRemoveConstructor()
{
- MutableClassInfo mci = new JavassistTypeInfoFactoryImpl().getMutable("org.jboss.test.plugins.javassist.support.PojoConstructor", null);
+ MutableClassInfo mci = new JavassistTypeInfoFactory().getMutable("org.jboss.test.plugins.javassist.support.PojoConstructor", null);
MutableConstructorInfo constructor;
try
{
Modified: projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistFieldInfoTestCase.java
===================================================================
--- projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistFieldInfoTestCase.java 2010-04-27 17:32:44 UTC (rev 104273)
+++ projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistFieldInfoTestCase.java 2010-04-27 17:36:57 UTC (rev 104274)
@@ -2,7 +2,7 @@
import junit.framework.Test;
-import org.jboss.reflect.plugins.javassist.JavassistTypeInfoFactoryImpl;
+import org.jboss.reflect.plugins.javassist.JavassistTypeInfoFactory;
import org.jboss.reflect.spi.ModifierInfo;
import org.jboss.reflect.spi.MutableClassInfo;
import org.jboss.reflect.spi.MutableFieldInfo;
@@ -23,7 +23,7 @@
public void testAddField()
{
- MutableClassInfo mci = new JavassistTypeInfoFactoryImpl().getMutable("org.jboss.test.plugins.javassist.support.PojoField", null);
+ MutableClassInfo mci = new JavassistTypeInfoFactory().getMutable("org.jboss.test.plugins.javassist.support.PojoField", null);
MutableFieldInfo foo = mci.getDeclaredField("foo");
assertEquals("java.lang.String", foo.getType().getName());
assertEquals(ModifierInfo.PUBLIC, foo.getModifiers());
@@ -34,7 +34,7 @@
public void testRemoveField()
{
- MutableClassInfo mci = new JavassistTypeInfoFactoryImpl().getMutable("org.jboss.test.plugins.javassist.support.PojoField", null);
+ MutableClassInfo mci = new JavassistTypeInfoFactory().getMutable("org.jboss.test.plugins.javassist.support.PojoField", null);
MutableFieldInfo foo = mci.getDeclaredField("foo");
mci.removeField(foo);
assertEquals(1, mci.getDeclaredFields().length);
Modified: projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistMutableMethodInfoTestCase.java
===================================================================
--- projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistMutableMethodInfoTestCase.java 2010-04-27 17:32:44 UTC (rev 104273)
+++ projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistMutableMethodInfoTestCase.java 2010-04-27 17:36:57 UTC (rev 104274)
@@ -24,7 +24,7 @@
import junit.framework.Test;
import org.jboss.reflect.plugins.javassist.InsertBeforeJavassistBody;
-import org.jboss.reflect.plugins.javassist.JavassistTypeInfoFactoryImpl;
+import org.jboss.reflect.plugins.javassist.JavassistTypeInfoFactory;
import org.jboss.reflect.spi.MutableClassInfo;
import org.jboss.reflect.spi.MutableMethodInfo;
import org.jboss.test.ContainerTest;
@@ -55,7 +55,7 @@
public void testMethods()
{
- MutableClassInfo mci = new JavassistTypeInfoFactoryImpl().getMutable("org.jboss.test.plugins.javassist.support.Pojo3", null);
+ MutableClassInfo mci = new JavassistTypeInfoFactory().getMutable("org.jboss.test.plugins.javassist.support.Pojo3", null);
MutableMethodInfo[] methods = mci.getDeclaredMethods();
try
@@ -75,7 +75,7 @@
public void testRemoveMethod()
{
- MutableClassInfo mci = new JavassistTypeInfoFactoryImpl().getMutable("org.jboss.test.plugins.javassist.support.Pojo3", null);
+ MutableClassInfo mci = new JavassistTypeInfoFactory().getMutable("org.jboss.test.plugins.javassist.support.Pojo3", null);
try
{
@@ -92,7 +92,7 @@
@SuppressWarnings("deprecation")
public void testNewMethods()
{
- MutableClassInfo mci = new JavassistTypeInfoFactoryImpl().getMutable("org.jboss.test.plugins.javassist.support.Pojo3", null);
+ MutableClassInfo mci = new JavassistTypeInfoFactory().getMutable("org.jboss.test.plugins.javassist.support.Pojo3", null);
MutableMethodInfo newMethod1 = mci.createMutableMethod(new InsertBeforeJavassistBody("public void test1() { }"));
mci.addMethod(newMethod1);
MutableMethodInfo newMethod2 = mci.createMutableMethod(new InsertBeforeJavassistBody("public String test2() { return \"foo\"; }"));
Modified: projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistMutableTypeInfoTestCase.java
===================================================================
--- projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistMutableTypeInfoTestCase.java 2010-04-27 17:32:44 UTC (rev 104273)
+++ projects/jboss-reflect/trunk/src/test/java/org/jboss/test/plugins/javassist/test/JavassistMutableTypeInfoTestCase.java 2010-04-27 17:36:57 UTC (rev 104274)
@@ -26,7 +26,7 @@
import junit.framework.Test;
import org.jboss.reflect.plugins.javassist.InsertBeforeJavassistBody;
-import org.jboss.reflect.plugins.javassist.JavassistTypeInfoFactoryImpl;
+import org.jboss.reflect.plugins.javassist.JavassistTypeInfoFactory;
import org.jboss.reflect.spi.MethodInfo;
import org.jboss.reflect.spi.MutableClassInfo;
import org.jboss.reflect.spi.MutableMethodInfo;
@@ -59,7 +59,7 @@
@SuppressWarnings("deprecation")
public void testNewClass()
{
- MutableClassInfo mci = new JavassistTypeInfoFactoryImpl().createNewMutableClass("org.jboss.test.plugins.javassist.PojoNew");
+ MutableClassInfo mci = new JavassistTypeInfoFactory().createNewMutableClass("org.jboss.test.plugins.javassist.PojoNew");
assertEquals(mci.getName(), "org.jboss.test.plugins.javassist.PojoNew");
assertEquals(mci.isPublic(), true);
MutableMethodInfo mmi1 = mci.createMutableMethod(new InsertBeforeJavassistBody("public String getFoo() { return \"foo\"; }"));
More information about the jboss-cvs-commits
mailing list