[jboss-cvs] JBossAS SVN: r109634 - branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent.

[jboss-cvs-commits at lists.jboss.org]

Author: thauser at redhat.com
Date: 2010-12-01 13:47:31 -0500 (Wed, 01 Dec 2010)
New Revision: 109634

Modified:
   branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java
Log:
more changes for displaying TimeTicks type.

Modified: branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java
===================================================================
--- branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java	2010-12-01 18:26:29 UTC (rev 109633)
+++ branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java	2010-12-01 18:47:31 UTC (rev 109634)
@@ -173,9 +173,6 @@
 		} 
 		response.setType(PDU.RESPONSE);
 		
-		//Start of MINE
-		//response = (PDU)pdu.clone();
-		
 		final boolean trace = log.isTraceEnabled();
 		
 			if (trace) {
@@ -587,41 +584,8 @@
         {
 			   Object val = server.getAttribute(be.mbean, be.attr.getName());
 			   ssy = prepForPdu(val);
-/*	// TODO: refactor all this type hogwash into a new method or even a new class.
-					if (val instanceof Long)
-	           {
-						Long uin = (Long) val;
-						
-						//consider Counter64 if there's problems
-						ssy = new Counter32(uin);
-					}
-	           else if (val instanceof String)
-	           {
-						String in = (String) val;
-						ssy = new OctetString(in.getBytes());
-					}
-	           else if (val instanceof Integer)
-	           {
-						Integer in = (Integer) val;
-						ssy = new Integer32(in);
-					}
-					
-					//not sure about how to handle this case yet
-	           else if (val instanceof OID)     
-	           {
-	        	   		ssy = new OID((OID)val);
-	           }
-	           else if (val instanceof TimeTicks)
-	           {
-	              ssy = (TimeTicks)val;
-	           }
-	           else if (val instanceof Counter32)
-	           {
-	        	   ssy = (Counter32) val;
-	           }
-	           else
-						log.info("Unknown type for " + be);*/
-				if (val == null){
+			   
+			   if (val == null){
 					log.info("Unknown type for " + be);
 				}
 				}
@@ -730,7 +694,7 @@
         }
         else if (val instanceof TimeTicks)
         {
-        	result = (TimeTicks)val;
+        	result = new OctetString(((TimeTicks)val).toString("{0} d {1} h {2} m {3} s {4} hs"));
         }
         else if (val instanceof Counter32)
         {