[jboss-cvs] JBossAS SVN: r109651 - branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent.

[jboss-cvs-commits at lists.jboss.org]

Author: thauser at redhat.com
Date: 2010-12-02 11:36:54 -0500 (Thu, 02 Dec 2010)
New Revision: 109651

Modified:
   branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java
Log:
more comments


Modified: branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java
===================================================================
--- branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java	2010-12-02 16:17:02 UTC (rev 109650)
+++ branches/snmp4j-integration-1.11.1/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java	2010-12-02 16:36:54 UTC (rev 109651)
@@ -157,6 +157,8 @@
     * @return a PDU filled with the appropriate values.
     * 
     */
+   
+   // this method is a work in progress.
    	public PDU snmpRecievedGetBulk(PDU pdu){
    		PDU response;
    		
@@ -203,22 +205,6 @@
 			}
 				
 			}
-			
-			
-			
-			
-/*			while (it.hasNext()){
-				VariableBinding vb = (VariableBinding)it.next();
-				OID oid = vb.getOid();
-				
-				newVB = new VariableBinding(oid);
-				//some errorchecking ....
-				//else is good and do:
-				var = getValueFor(oid);
-				
-					newVB.setVariable(var);
-					response.add(newVB);
-					}*/
 		return response;
    	}
    
@@ -240,7 +226,6 @@
 	public PDU snmpReceivedGet(PDU pdu)
 	{
 		PDU response;
-		//later on should be able to get rid of getNext because pdu.getType() should have it
 		if (pdu instanceof ScopedPDU){
 			response = DefaultPDUFactory.createPDU(SnmpConstants.version3);
 		} else if (pdu instanceof PDUv1){
@@ -287,6 +272,7 @@
 		return response;
 	}	
 		
+	/** Brian Shim commented this out for reference i'm guessing **/
 //		try
 //		{
 //			SnmpPduRequest response = null;
@@ -428,8 +414,6 @@
 					log.debug("attempt to set value resulted in a null PDU being returned.");
 					response = null;
 				}
-				//null on success. change this;
-			//	newVB.setVariable(var);
 				response.add(newVB);
 			}
 		}
@@ -665,7 +649,7 @@
 			   if (val == null){
 					log.info("Unknown type for " + be);
 				}
-				}
+		}
 
         catch (Exception e)
         {