[jboss-cvs] JBossAS SVN: r110101 - branches/JBPAPP_5_1/server/src/main/org/jboss/ejb/txtimer.

[jboss-cvs-commits at lists.jboss.org]

Author: bmaxwell
Date: 2010-12-21 11:57:49 -0500 (Tue, 21 Dec 2010)
New Revision: 110101

Modified:
   branches/JBPAPP_5_1/server/src/main/org/jboss/ejb/txtimer/GeneralPurposeDatabasePersistencePlugin.java
Log:
[JBPAPP-5618] GeneralPurposeDatabasePersistencePlugin not closing ResultSet in isNextDateColumnPresent

Modified: branches/JBPAPP_5_1/server/src/main/org/jboss/ejb/txtimer/GeneralPurposeDatabasePersistencePlugin.java
===================================================================
--- branches/JBPAPP_5_1/server/src/main/org/jboss/ejb/txtimer/GeneralPurposeDatabasePersistencePlugin.java	2010-12-21 16:02:26 UTC (rev 110100)
+++ branches/JBPAPP_5_1/server/src/main/org/jboss/ejb/txtimer/GeneralPurposeDatabasePersistencePlugin.java	2010-12-21 16:57:49 UTC (rev 110101)
@@ -582,6 +582,7 @@
       // is only there to take care of already existing Timer table, this impl should be OK for now
       Connection con = null;
       PreparedStatement st = null;
+      ResultSet rs = null;
       try
       {
          con = ds.getConnection();
@@ -592,7 +593,7 @@
          st = con.prepareStatement(sql);
          st.setString(1, "");
 
-         st.executeQuery();
+         rs = st.executeQuery();
          return true;
 
       }
@@ -607,6 +608,7 @@
       }
       finally
       {
+         JDBCUtil.safeClose(rs);
          JDBCUtil.safeClose(st);
          JDBCUtil.safeClose(con);
       }