[jboss-cvs] jboss-cvs-commits Digest, Vol 44, Issue 151

[Thomas Diesler]

OSGi is going to be at the bottom of the stack - especially there we 
need maintainable code that is well documented and can be understood by 
many. This is a prerequisite that enables folks like me (and in the 
future hopefully others) to make qualified changes. [JBOSGI-278] is 
about improvement in that area - we can have a separate discussion on 
this particular jira issue and what is left to be done elsewhere.

If you have some javadoc that's good. You can commit that on a branch 
you take from -r100671. I'll be happy to pick it up and feed it into 
trunk as I understand that this might conflict with my latest JBOSGI-287 
commit. There should be no additional cost for you - and yes, 
comprehensive docs is very important to me.

With respect to the [JBOSGI-141] rollback issue, I suggest we step back 
a little and I explain again why it is so vitally important that the 
OSGi stuff actually runs in AS and not just on the local mvn command 
line. When we have a common understanding on this, we can hopefully come 
up with a procedure that we can follow such that roll backs will not be 
necessary or be justified.

Again, all it takes is to put the stuff you want to have updated in AS 
in the installer. This should not be a big deal.

I don't know any other way to verify that an intended update is indeed 
valid.

cheers
-thomas


On 02/10/2010 02:59 PM, Ales Justin wrote:
> Since we're on picking-the-annoying stuff subject. ;-)
>
> On one hand, you're complaining about lack of docs for the stuff I've done.
> On the other, you're constantly refactoring/reverting my stuff.
> How do you expect me to do any work - actual code or plain javadocs?
>
> I just hope this constant refactoring/reverting didn't "scare" Adrian away,
> as he tried to push in some of his stuff, but it was just too big of pita to do it.
>
> We need to get past this refactoring/reverting obsession w/o any warning in advance.
> But I'm out of ideas on how to prevent you from doing this, as nothing helped so far.
>
> If there are Hudson issues, let me know about them, and I'll have a look.
> It might be a simple fix, as was in JMX case.
> After all, why do you have Hudson runs if not for this,
> but then it doesn't mean you have to revert things in an instance - it's not like we're few hours away from new major release.
>
> ps: I actually had some javadoc ready, just saw now it's impossible for me to commit it as you combined the revert with new CCPlugin refactoring ...
>
> On Feb 10, 2010, at 2:24 PM, Thomas Diesler wrote:
>
>    
>> I might need to add: When you do put stuff in the installer that overwrites critical components in
>> AS, please make sure the AS starts up at least.
>>
>> cheers
>> -thoams
>>
>> On 02/10/2010 02:18 PM, Thomas Diesler wrote:
>>      
>>> I tried hard to make it work for you. Unfortunately its not just the missing update you were talking about.
>>> Believe me, I also rather not rollback work. However those commits broke fundamental service handling functionality to a degree where everything stopped working in AS. A working AS integration is however needed for much of the work I do.
>>>
>>> We don't need to get political on this. A valid commit needs to pass the local testsuite, which is a prerequisite of TCK runs. It should also not break the AS integration in a fundamental way. If something needs to be installed in AS, the installer can do that.
>>>
>>> I don't ask you to run the AS tests for every commit, but I do ask you to respect the nightly Hudson runs that pick up broken functionality that might work standalone.
>>>
>>> All I am asking is: Put the stuff in the installer that you want to have in AS. The day after you will know whether it really worked in AS as well.
>>>
>>> On 02/10/2010 11:57 AM, Ales Justin wrote:
>>>        
>>>> Can you please revert this, as this is getting childish and ridiculous.
>>>> I said that Kernel 2.2.0.Alpha6 is gonna be in AS in a day -- today.
>>>>
>>>> The framework itself is not broken,
>>>> and AS - afaik - can easily be updated via installer with new Kernel version,
>>>> if you're really in such a hurry.
>>>>
>>>> Your constant unjustified reverting/refactoring is very annoying,
>>>> Adrian expressed it already, now I'm expressing it as well.
>>>> If you want us to help you, this is not the way to go, and needs an immediate change of attitude.
>>>>
>>>> I would understand if the framework itself was broken, which is not.
>>>> When you broke it a couple of days ago, I worked around the issue.
>>>> Not to mention the lack of willingness to support other OS envs with your native code -- which was all likely candidate for reverting as well.
>>>>
>>>> OSGi+MC is not WS or jBPM, hence needs different approach on how to tests it. ;-)
>>>> * http://community.jboss.org/message/525198#525198
>>>>
>>>>          
>>>>> Message: 4
>>>>> Date: Wed, 10 Feb 2010 05:39:46 -0500
>>>>> From: jboss-cvs-commits at lists.jboss.org
>>>>> Subject: [jboss-cvs] JBossAS SVN: r100793 - in projects/jboss-osgi:
>>>>>     projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle
>>>>>     and 9 other directories.
>>>>> To: jboss-cvs-commits at lists.jboss.org
>>>>> Message-ID:
>>>>> <201002101039.o1AAdk9a030469 at svn01.web.mwc.hst.phx2.redhat.com>
>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>
>>>>> Author: thomas.diesler at jboss.com
>>>>> Date: 2010-02-10 05:39:45 -0500 (Wed, 10 Feb 2010)
>>>>> New Revision: 100793
>>>>>
>>>>> Removed:
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/AbstractDictionaryFactory.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/JMXDictionaryFactory.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/java/org/jboss/test/osgi/service/support/a/AMBean.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/java/org/jboss/test/osgi/service/support/c/CMBean.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/resources/bundles/service/service-jmx1/
>>>>> Modified:
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/pom.xml
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/AbstractBundleState.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/DescribeAction.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/KernelDictionaryFactory.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/OSGiBundleState.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/OSGiServiceReferenceWrapper.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/PreInstallAction.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/bundle/ServiceManagerPluginImpl.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/main/java/org/jboss/osgi/framework/plugins/ServiceManagerPlugin.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/java/org/jboss/test/osgi/DeployersTest.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/java/org/jboss/test/osgi/service/JMXServicesUnitTestCase.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/java/org/jboss/test/osgi/service/ServiceMixUnitTestCase.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/java/org/jboss/test/osgi/service/ServicesTest.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/java/org/jboss/test/osgi/service/support/a/A.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/java/org/jboss/test/osgi/service/support/c/C.java
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/resources/bootstrap/jboss-osgi-bootstrap.xml
>>>>>    projects/jboss-osgi/projects/runtime/framework/trunk/src/test/resources/org/jboss/test/osgi/service/JMXServicesUnitTestCase.xml
>>>>>    projects/jboss-osgi/trunk/distribution/installer/src/main/resources/installer/install-definition.xml
>>>>> Log:
>>>>> [JBOSGI-141] Restore AS integration to a working state
>>>>>            
>>>        
>> -- 
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Thomas Diesler
>> JBoss OSGi Lead
>> JBoss, a division of Red Hat
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>
>>      
>    

-- 
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx