[jboss-cvs] JBossAS SVN: r101994 - trunk/tomcat/src/main/java/org/jboss/web/tomcat/service/session.

[jboss-cvs-commits at lists.jboss.org]

Author: bstansberry at jboss.com
Date: 2010-03-05 16:13:21 -0500 (Fri, 05 Mar 2010)
New Revision: 101994

Modified:
   trunk/tomcat/src/main/java/org/jboss/web/tomcat/service/session/JBossManager.java
Log:
Improve error message when mbean registration fails

Modified: trunk/tomcat/src/main/java/org/jboss/web/tomcat/service/session/JBossManager.java
===================================================================
--- trunk/tomcat/src/main/java/org/jboss/web/tomcat/service/session/JBossManager.java	2010-03-05 21:12:55 UTC (rev 101993)
+++ trunk/tomcat/src/main/java/org/jboss/web/tomcat/service/session/JBossManager.java	2010-03-05 21:13:21 UTC (rev 101994)
@@ -1120,6 +1120,7 @@
     */
    protected void registerManagerMBean() 
    {
+      String objname = null;
       try
       {
          MBeanServer server = getMBeanServer();
@@ -1137,9 +1138,8 @@
          hostName = (hostName == null) ? "localhost" : hostName;
          String path = ((Context) container_).getPath();
          path = "".equals(path) ? "/" : path; 
-         ObjectName clusterName = new ObjectName(domain
-               + ":type=Manager,host=" + hostName + ",path="
-               + path);
+         objname = domain + ":type=Manager,host=" + hostName + ",path=" + path;
+         ObjectName clusterName = new ObjectName(objname);
 
          if (server.isRegistered(clusterName))
          {
@@ -1152,7 +1152,15 @@
       }
       catch (Exception ex)
       {
-         log_.error("Could not register " + getClass().getSimpleName() + " to MBeanServer", ex);
+         if (objname == null)
+         {
+            log_.error("Could not register " + getClass().getSimpleName() + " with MBeanServer", ex);
+         }
+         else
+         {
+            log_.error("Could not register " + getClass().getSimpleName() + 
+                  " with MBeanServer under ObjectName " + objname, ex);
+         }
       }
    }