[jboss-cvs] JBossAS SVN: r102731 - projects/metadata/common/trunk/src/test/java/org/jboss/test/metadata/jbmeta271/unit.

[jboss-cvs-commits at lists.jboss.org]

Author: jaikiran
Date: 2010-03-22 15:00:47 -0400 (Mon, 22 Mar 2010)
New Revision: 102731

Modified:
   projects/metadata/common/trunk/src/test/java/org/jboss/test/metadata/jbmeta271/unit/PersistenceContextProcessorTestCase.java
Log:
JBMETA-271 Added javadoc to testcase

Modified: projects/metadata/common/trunk/src/test/java/org/jboss/test/metadata/jbmeta271/unit/PersistenceContextProcessorTestCase.java
===================================================================
--- projects/metadata/common/trunk/src/test/java/org/jboss/test/metadata/jbmeta271/unit/PersistenceContextProcessorTestCase.java	2010-03-22 18:56:58 UTC (rev 102730)
+++ projects/metadata/common/trunk/src/test/java/org/jboss/test/metadata/jbmeta271/unit/PersistenceContextProcessorTestCase.java	2010-03-22 19:00:47 UTC (rev 102731)
@@ -23,7 +23,6 @@
 
 import java.lang.reflect.AnnotatedElement;
 import java.lang.reflect.Field;
-import java.util.Collection;
 import java.util.Set;
 
 import junit.framework.Assert;
@@ -34,13 +33,13 @@
 import org.jboss.metadata.javaee.spec.PersistenceContextReferenceMetaData;
 import org.jboss.metadata.javaee.spec.PersistenceContextReferencesMetaData;
 import org.jboss.metadata.javaee.spec.ResourceInjectionTargetMetaData;
-import org.jboss.test.metadata.common.PackageScanner;
-import org.jboss.test.metadata.common.ScanPackage;
 import org.jboss.test.metadata.jbmeta271.SimpleClassWithPersistenceContextInjection;
 import org.junit.Test;
 
 /**
- * PersistenceContextProcessorTestCase
+ * Tests the bug fix for JBMETA-271 (where the injection target name 
+ * for a @PersistenceContext injection on a field was using the ENC name instead of
+ * field name)
  *
  * @author Jaikiran Pai
  * @version $Revision: $
@@ -48,29 +47,38 @@
 public class PersistenceContextProcessorTestCase
 {
 
+   /**
+    * Tests that the injection target name generated for a @PersistenceContext
+    * field injection uses the name of the {@link Field} and not the ENC name
+    *  
+    */
    @Test
    public void testPersistenceContextAnnotationProcessing() throws Exception
    {
       AnnotationFinder<AnnotatedElement> finder = new DefaultAnnotationFinder<AnnotatedElement>();
       PersistenceContextFieldProcessor pcFieldProcessor = new PersistenceContextFieldProcessor(finder);
       Field field = SimpleClassWithPersistenceContextInjection.class.getDeclaredField("emFieldName");
-      
+
       PersistenceContextReferencesMetaData pcRefs = new PersistenceContextReferencesMetaData();
       pcFieldProcessor.process(pcRefs, field);
-      
-      Assert.assertEquals("Unexpected number of persistence context references",1, pcRefs.size());
-      
+
+      Assert.assertEquals("Unexpected number of persistence context references", 1, pcRefs.size());
+
       PersistenceContextReferenceMetaData pcRef = PersistenceContextReferencesMetaData.getByName("emENCName", pcRefs);
-      
+
       Assert.assertNotNull("PersistenceContext reference not found", pcRef);
       Set<ResourceInjectionTargetMetaData> injectionTargets = pcRef.getInjectionTargets();
       Assert.assertNotNull("Injection targets for persistence context reference not found", injectionTargets);
-      
-      Assert.assertEquals("Unexpected number of injection targets found",1, injectionTargets.size());
+
+      Assert.assertEquals("Unexpected number of injection targets found", 1, injectionTargets.size());
       for (ResourceInjectionTargetMetaData injectionTarget : injectionTargets)
       {
-         Assert.assertEquals("Unexpected injection target class name", SimpleClassWithPersistenceContextInjection.class.getName(), injectionTarget.getInjectionTargetClass());
-         Assert.assertEquals("Unexpected injection target targetName", field.getName(), injectionTarget.getInjectionTargetName());
+         // ensure that the correct target class name is set
+         Assert.assertEquals("Unexpected injection target class name", SimpleClassWithPersistenceContextInjection.class
+               .getName(), injectionTarget.getInjectionTargetClass());
+         // ensure correct injection target name
+         Assert.assertEquals("Unexpected injection target targetName", field.getName(), injectionTarget
+               .getInjectionTargetName());
       }
    }
 }