[jboss-cvs] JBossAS SVN: r103020 - projects/test/trunk/src/main/java/org/jboss/test/jms.

[jboss-cvs-commits at lists.jboss.org]

Author: wolfc
Date: 2010-03-26 05:53:10 -0400 (Fri, 26 Mar 2010)
New Revision: 103020

Modified:
   projects/test/trunk/src/main/java/org/jboss/test/jms/LegacyJMSTestAdmin.java
Log:
JBTEST-17: quoting all attributes

Modified: projects/test/trunk/src/main/java/org/jboss/test/jms/LegacyJMSTestAdmin.java
===================================================================
--- projects/test/trunk/src/main/java/org/jboss/test/jms/LegacyJMSTestAdmin.java	2010-03-26 09:33:53 UTC (rev 103019)
+++ projects/test/trunk/src/main/java/org/jboss/test/jms/LegacyJMSTestAdmin.java	2010-03-26 09:53:10 UTC (rev 103020)
@@ -22,17 +22,16 @@
 
 package org.jboss.test.jms;
 
+import org.jboss.logging.Logger;
+
+import javax.management.MBeanServerConnection;
+import javax.management.ObjectName;
+import javax.naming.InitialContext;
 import java.io.File;
 import java.io.FileOutputStream;
 import java.io.PrintStream;
 import java.util.Map;
 
-import javax.management.MBeanServerConnection;
-import javax.management.ObjectName;
-import javax.naming.InitialContext;
-
-import org.jboss.logging.Logger;
-
 /**
  * 
  * @author <mailto:clebert.suconic at jboss.org">Clebert Suconic</a>
@@ -222,16 +221,19 @@
       if (securityConfig != null && securityConfig.length > 0)
       {
          str.println("    <attribute name=\"SecurityConf\">");
-         str.println("       <security>");
+         str.println("      <security>");
          for (TestRole role : securityConfig)
          {
-            str.println("       <role name=\"" + role.getName() + "\" read=" + role.isConsume() + " write=" + role.isSend() + " create=" + (role.isCreateDurableQueue() || role.isCreateNonDurableQueue()) + "/>");
+            str.println("        <role name=" + q(role.getName()) +
+               " read=" + q(role.isConsume()) +
+               " write=" + q(role.isSend()) +
+               " create=" + q(role.isCreateDurableQueue() || role.isCreateNonDurableQueue()) + "/>");
          }
-         str.println("   </security>");
-         str.println("</attribute>");
+         str.println("      </security>");
+         str.println("    </attribute>");
       }
       
-      str.println("   </mbean>");
+      str.println("  </mbean>");
 
       str.println("</server>");
 
@@ -252,4 +254,8 @@
       return fileout;
    }
 
+   private static final String q(Object s)
+   {
+      return "\"" + s + "\"";
+   }
 }