[jboss-cvs] Picketlink SVN: r236 - federation/trunk/picketlink-seam/src/main/java/org/picketlink/identity/seam/federation.

[jboss-cvs-commits at lists.jboss.org]

Author: anil.saldhana at jboss.com
Date: 2010-05-04 13:01:39 -0400 (Tue, 04 May 2010)
New Revision: 236

Modified:
   federation/trunk/picketlink-seam/src/main/java/org/picketlink/identity/seam/federation/ExternalAuthenticator.java
Log:
PLFED-68: throw a meaningful exception instead of NPE

Modified: federation/trunk/picketlink-seam/src/main/java/org/picketlink/identity/seam/federation/ExternalAuthenticator.java
===================================================================
--- federation/trunk/picketlink-seam/src/main/java/org/picketlink/identity/seam/federation/ExternalAuthenticator.java	2010-05-03 17:00:47 UTC (rev 235)
+++ federation/trunk/picketlink-seam/src/main/java/org/picketlink/identity/seam/federation/ExternalAuthenticator.java	2010-05-04 17:01:39 UTC (rev 236)
@@ -135,7 +135,10 @@
             url.append("=");
             try
             {
-               url.append(URLEncoder.encode(paramEntry.getValue(), "UTF-8"));
+               String paramValue = paramEntry.getValue();
+               if( paramValue == null || paramValue == "" )
+                  throw new RuntimeException( "Param Key:" + paramEntry.getKey() + " has value that is null" );
+               url.append(URLEncoder.encode( paramValue, "UTF-8" ));
             }
             catch (UnsupportedEncodingException e)
             {