[jboss-cvs] JBossAS SVN: r104635 - projects/cluster/ha-server-cache-jbc/trunk/src/main/java/org/jboss/web/tomcat/service/session/distributedcache/impl/jbc.

jboss-cvs-commits at lists.jboss.org jboss-cvs-commits at lists.jboss.org
Mon May 10 17:07:28 EDT 2010


Author: bstansberry at jboss.com
Date: 2010-05-10 17:07:27 -0400 (Mon, 10 May 2010)
New Revision: 104635

Modified:
   projects/cluster/ha-server-cache-jbc/trunk/src/main/java/org/jboss/web/tomcat/service/session/distributedcache/impl/jbc/AbstractJBossCacheService.java
Log:
[JBCLUSTER-269] Remove JBCACHE-1580 workaround

Modified: projects/cluster/ha-server-cache-jbc/trunk/src/main/java/org/jboss/web/tomcat/service/session/distributedcache/impl/jbc/AbstractJBossCacheService.java
===================================================================
--- projects/cluster/ha-server-cache-jbc/trunk/src/main/java/org/jboss/web/tomcat/service/session/distributedcache/impl/jbc/AbstractJBossCacheService.java	2010-05-10 20:51:57 UTC (rev 104634)
+++ projects/cluster/ha-server-cache-jbc/trunk/src/main/java/org/jboss/web/tomcat/service/session/distributedcache/impl/jbc/AbstractJBossCacheService.java	2010-05-10 21:07:27 UTC (rev 104635)
@@ -615,27 +615,9 @@
                Fqn<String> ownerFqn = owner.getFqn();
                if (Util.isBuddyOwnerDead(ownerFqn))
                {
-                  Set<Object> ownerVersions = owner.getChildrenNames();                  
-                  for (Object ownerVersion : ownerVersions)
+                  for (Node<Object, Object> ownerVersion : owner.getChildren())
                   {
-                     // If we pulled node from FileCacheLoader, the type will
-                     // be String, which is incorrect
-                     boolean correctType = ownerVersion instanceof Integer;
-                     
-                     Integer versionInt = correctType ? 
-                           (Integer) ownerVersion : Integer.valueOf(ownerVersion.toString());
-                     Node<Object, Object> versionNode = owner.getChild(versionInt);
-                     
-                     if (!correctType)
-                     {
-                        // We loaded a node with a bogus name type from FileCacheLoader.
-                        // We need to evict it or it will screw up JBC code that assumes
-                        // all names at this point in the tree are Integer
-                        Fqn<Object> bogus = Fqn.fromRelativeElements(ownerFqn, ownerVersion);
-                        this.cacheWrapper_.removeLocal(bogus);
-                     }
-                     
-                     storeSessionIdsForOwner(versionNode, webappFqn, result);
+                     storeSessionIdsForOwner(ownerVersion, webappFqn, result);
                   }
                }
                else
@@ -825,17 +807,6 @@
       Set<Object> buddies = plainCache_.getChildrenNames(dead); // won't return null
       for (Object child : buddies)
       {
-         if (!(child instanceof Integer))
-         {
-            log_.warn("Found child of type " + child.getClass() + " under fqn " + dead, new Exception("Just a stack trace"));
-            Object orig = child;
-            child = Integer.valueOf(orig.toString());
-            // In case we loaded a node with a bogus name type from FileCacheLoader
-            // we need to evict it or it will screw up JBC code that assumes
-            // all names at this point in the tree are Integer
-            Fqn<Object> bogus = Fqn.fromElements(BUDDY_BACKUP, deadBuddy, orig);
-            this.cacheWrapper_.removeLocal(bogus);            
-         }
          result.add(Fqn.fromElements(BUDDY_BACKUP, deadBuddy, child, SESSION, contextHostPath, sessionId));
       }
       return result;




More information about the jboss-cvs-commits mailing list