[jboss-cvs] JBossAS SVN: r109138 - in projects/jboss-jca/trunk: common/src/test/java/org/jboss/jca/common/metadata/ironjacamar and 1 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: jesper.pedersen
Date: 2010-11-04 15:46:29 -0400 (Thu, 04 Nov 2010)
New Revision: 109138

Modified:
   projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/AbstractParser.java
   projects/jboss-jca/trunk/common/src/test/java/org/jboss/jca/common/metadata/ironjacamar/IronJacamarParserTestCase.java
   projects/jboss-jca/trunk/core/src/test/java/org/jboss/jca/core/connectionmanager/unit/pool/PoolConfigurationTestCase.java
Log:
Prefill should be true by default

Modified: projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/AbstractParser.java
===================================================================
--- projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/AbstractParser.java	2010-11-04 19:12:23 UTC (rev 109137)
+++ projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/AbstractParser.java	2010-11-04 19:46:29 UTC (rev 109138)
@@ -285,7 +285,7 @@
    {
       Integer minPoolSize = null;
       Integer maxPoolSize = null;
-      boolean prefill = false;
+      boolean prefill = true;
       boolean interleaving = false;
       boolean isSameRmOverrideValue = false;
       boolean padXid = false;

Modified: projects/jboss-jca/trunk/common/src/test/java/org/jboss/jca/common/metadata/ironjacamar/IronJacamarParserTestCase.java
===================================================================
--- projects/jboss-jca/trunk/common/src/test/java/org/jboss/jca/common/metadata/ironjacamar/IronJacamarParserTestCase.java	2010-11-04 19:12:23 UTC (rev 109137)
+++ projects/jboss-jca/trunk/common/src/test/java/org/jboss/jca/common/metadata/ironjacamar/IronJacamarParserTestCase.java	2010-11-04 19:46:29 UTC (rev 109138)
@@ -410,7 +410,7 @@
             assertThat(connDef.isXa(), is(false));
             assertThat(connDef.getPool().getMinPoolSize(), new IsNull<Integer>());
             assertThat(connDef.getPool().getMaxPoolSize(), new IsNull<Integer>());
-            assertThat(connDef.getPool().isPrefill(), is(false));
+            assertThat(connDef.getPool().isPrefill(), is(true));
             assertThat(connDef.getPool().isUseStrictMin(), is(false));
 
             //security defaults
@@ -472,7 +472,7 @@
             assertThat(connDef.isXa(), is(true));
             assertThat(connDef.getPool().getMinPoolSize(), new IsNull<Integer>());
             assertThat(connDef.getPool().getMaxPoolSize(), new IsNull<Integer>());
-            assertThat(connDef.getPool().isPrefill(), is(false));
+            assertThat(connDef.getPool().isPrefill(), is(true));
             assertThat(connDef.getPool().isUseStrictMin(), is(false));
 
             //security defaults

Modified: projects/jboss-jca/trunk/core/src/test/java/org/jboss/jca/core/connectionmanager/unit/pool/PoolConfigurationTestCase.java
===================================================================
--- projects/jboss-jca/trunk/core/src/test/java/org/jboss/jca/core/connectionmanager/unit/pool/PoolConfigurationTestCase.java	2010-11-04 19:12:23 UTC (rev 109137)
+++ projects/jboss-jca/trunk/core/src/test/java/org/jboss/jca/core/connectionmanager/unit/pool/PoolConfigurationTestCase.java	2010-11-04 19:46:29 UTC (rev 109138)
@@ -110,9 +110,9 @@
    public void testIsPrefill()
    {
       PoolConfiguration params = new PoolConfiguration();
+      assertTrue("Prefill must be true", params.isPrefill());
+      params.setPrefill(false);
       assertFalse("Prefill must be false", params.isPrefill());
-      params.setPrefill(true);
-      assertTrue("Prefill must be true", params.isPrefill());
    }
 
    /**