[jboss-cvs] JBossAS SVN: r110473 - branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent.

[jboss-cvs-commits at lists.jboss.org]

Author: thauser at redhat.com
Date: 2011-01-27 16:36:11 -0500 (Thu, 27 Jan 2011)
New Revision: 110473

Modified:
   branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/AttributeMappingsBinding.java
Log:
add comment to explain new parsing scheme which would allow conceptual tabular data structures in the AS attributes.xml (and a more accurate SNMP agent implementation)

Modified: branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/AttributeMappingsBinding.java
===================================================================
--- branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/AttributeMappingsBinding.java	2011-01-27 16:06:35 UTC (rev 110472)
+++ branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/AttributeMappingsBinding.java	2011-01-27 21:36:11 UTC (rev 110473)
@@ -35,6 +35,25 @@
 /**
  * Parse the mapping of JMX mbean attributes to SNMP OIDs
  * 
+ * TODO: extend this parsing. 
+ * 		-Add "table" element. This is not represented by any MBean attribute but is still recorded by the system,
+ *       as a a way to conceptually organize the desired exposed JMX metrics. This element would have the oid-prefix
+ *       attribute, which would replace the mbean oid-prefix 
+ *      -Remove the ability for there to be an oid-prefix for the MBeans. instead, but this into the "table" element.
+ *       the reason we should do this is because SNMP works with "Objects" and "Instances". The way it is currently
+ *       parsed makes it seem like each MIB is a table, and we do not want to force this behavior.
+ *      
+ *      New scheme for parsing: 
+ *      <mbean name=...> (MBean we're interested in.)
+ *         <attribute name=... oid="1.2.3.4.1.0"/> (This attribute is a scalar, because it has no prefix. it's Object is 1.2.3.4.1 and the instance is 0) 
+ *         ..
+ *         <table name=... oid-prefix="1.2.3.4.1.8"/>  (This indicates the creation of a conceptual table.)
+ *         	 <row name=... oid=".1"/> (This is a row in the table) neither this nor the table are directly accessible in SNMP.
+ *            <attribute name=... oid=".1"/> (this is an actual instance of the row (a single column in the row.) 
+ *            								 This attribute is accessed by 1.2.3.4.1.8.1.1 <tableOID><rowOID><instanceOID>
+ *          ..
+ *      </mbean>
+ * 
  * @author <a href="mailto:hwr at pilhuhn.de">Heiko W. Rupp</a>
  * @version $Revision$
  */