[jboss-cvs] JBossAS SVN: r110491 - branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent.

[jboss-cvs-commits at lists.jboss.org]

Author: thauser at redhat.com
Date: 2011-01-28 12:25:40 -0500 (Fri, 28 Jan 2011)
New Revision: 110491

Modified:
   branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java
Log:
Fixed some comments; modified the addition to the objectKey set

Modified: branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java
===================================================================
--- branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java	2011-01-28 17:02:49 UTC (rev 110490)
+++ branches/snmp4j-int/varia/src/main/java/org/jboss/jmx/adaptor/snmp/agent/RequestHandlerImpl.java	2011-01-28 17:25:40 UTC (rev 110491)
@@ -707,9 +707,8 @@
 			  }
 			  else{
 				  oid = ma.getOid();
-				  OID trimOID = new OID(oid);
-				  trimOID = trimOID.trim();
-      			  addObjectEntry(trimOID.toString());
+				  OID objectOID = new OID(oid);
+      			  addObjectEntry(objectOID.trim());
 			  }
 			 
 			  addBindEntry(oid, mmb.getName(), ma.getName(),ma.isReadWrite());
@@ -719,15 +718,17 @@
       }
    }
 	
-	/** test method **/
-	private void addObjectEntry(String oid){
-		OID coid = new OID(oid);
-		if (objectKeys.contains(coid))
+	/** This method adds a new ObjectEntry to the set of Object OIDs.
+	 * @param String representation of the OID to add. 
+	 * 
+	 * **/
+	private void addObjectEntry(OID oid){
+		if (objectKeys.contains(oid))
 			log.debug("duplicate object " + oid + SKIP_ENTRY);
 		
 		if (oid == null)
 			log.debug("null oid for object");
-		objectKeys.add(coid);
+		objectKeys.add(oid);
 				
 	}