[jboss-cvs] Picketlink SVN: r1319 - in federation/trunk/picketlink-bindings/src: test/resources/responseIDP and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: anil.saldhana at jboss.com
Date: 2011-11-07 14:50:57 -0500 (Mon, 07 Nov 2011)
New Revision: 1319

Modified:
   federation/trunk/picketlink-bindings/src/main/java/org/picketlink/identity/federation/bindings/tomcat/sp/SPPostFormAuthenticator.java
   federation/trunk/picketlink-bindings/src/main/java/org/picketlink/identity/federation/bindings/tomcat/sp/SPRedirectFormAuthenticator.java
   federation/trunk/picketlink-bindings/src/test/resources/responseIDP/casidp.xml
Log:
PLFED-245: exception logging

Modified: federation/trunk/picketlink-bindings/src/main/java/org/picketlink/identity/federation/bindings/tomcat/sp/SPPostFormAuthenticator.java
===================================================================
--- federation/trunk/picketlink-bindings/src/main/java/org/picketlink/identity/federation/bindings/tomcat/sp/SPPostFormAuthenticator.java	2011-11-04 18:19:34 UTC (rev 1318)
+++ federation/trunk/picketlink-bindings/src/main/java/org/picketlink/identity/federation/bindings/tomcat/sp/SPPostFormAuthenticator.java	2011-11-07 19:50:57 UTC (rev 1319)
@@ -198,8 +198,7 @@
       }
       catch (Exception e)
       {
-         if (trace)
-            log.trace("Server Exception:", e);
+         log.error("Server Exception:", e);
          throw new IOException(ErrorCodes.SERVICE_PROVIDER_SERVER_EXCEPTION);
       }
       return localAuthentication(request, response, loginConfig);
@@ -317,6 +316,7 @@
             //Just issue a fresh request back to IDP
             return generalUserRequest(request, response, loginConfig);
          }
+         log.error("Server Exception:", pe);
          throw new IOException(ErrorCodes.SERVICE_PROVIDER_SERVER_EXCEPTION + pe.getLocalizedMessage());
       }
       catch (Exception e)
@@ -393,8 +393,7 @@
          }
          catch (Exception e)
          {
-            if (trace)
-               log.trace("Exception:", e);
+            log.error("Server Exception:", e);
             throw new IOException(ErrorCodes.SERVICE_PROVIDER_SERVER_EXCEPTION);
          }
       }

Modified: federation/trunk/picketlink-bindings/src/main/java/org/picketlink/identity/federation/bindings/tomcat/sp/SPRedirectFormAuthenticator.java
===================================================================
--- federation/trunk/picketlink-bindings/src/main/java/org/picketlink/identity/federation/bindings/tomcat/sp/SPRedirectFormAuthenticator.java	2011-11-04 18:19:34 UTC (rev 1318)
+++ federation/trunk/picketlink-bindings/src/main/java/org/picketlink/identity/federation/bindings/tomcat/sp/SPRedirectFormAuthenticator.java	2011-11-07 19:50:57 UTC (rev 1319)
@@ -332,12 +332,12 @@
             //Just issue a fresh request back to IDP
             return generalUserRequest(request, response, loginConfig);
          }
+         log.error("Server Exception:", pe);
          throw new IOException(ErrorCodes.SERVICE_PROVIDER_SERVER_EXCEPTION + pe.getLocalizedMessage());
       }
       catch (Exception e)
       {
-         if (trace)
-            log.trace("Server Exception:", e);
+         log.error("Server Exception:", e);
          throw new IOException(ErrorCodes.SERVICE_PROVIDER_SERVER_EXCEPTION + e.getLocalizedMessage());
       }
       return localAuthentication(request, response, loginConfig);
@@ -426,8 +426,7 @@
          }
          catch (Exception e)
          {
-            if (trace)
-               log.trace("Exception:", e);
+            log.error("Server Exception:", e);
             throw new IOException(ErrorCodes.SERVICE_PROVIDER_SERVER_EXCEPTION);
          }
       }

Modified: federation/trunk/picketlink-bindings/src/test/resources/responseIDP/casidp.xml
===================================================================
--- federation/trunk/picketlink-bindings/src/test/resources/responseIDP/casidp.xml	2011-11-04 18:19:34 UTC (rev 1318)
+++ federation/trunk/picketlink-bindings/src/test/resources/responseIDP/casidp.xml	2011-11-07 19:50:57 UTC (rev 1319)
@@ -19,7 +19,7 @@
 					InResponseTo="ID_8b7b580b-592a-49ba-b55e-b2ef2bbefb51" />
 			</SubjectConfirmation>
 		</Subject>
-		<Conditions NotBefore="2011-11-04T09:42:04Z" NotOnOrAfter="2011-11-05T09:42:04Z" />
+		<Conditions NotBefore="2011-11-04T09:42:04Z" NotOnOrAfter="2051-11-05T09:42:04Z" />
 		<AuthnStatement AuthnInstant="2011-11-04T09:42:04Z">
 			<AuthnContext>
 				<AuthnContextClassRef>urn:oasis:names:tc:SAML:2.0:ac:classes:Password