From jboss-cvs-commits at lists.jboss.org Fri May 8 22:11:56 2015 From: jboss-cvs-commits at lists.jboss.org (jboss-cvs-commits at lists.jboss.org) Date: Fri, 8 May 2015 22:11:56 -0400 Subject: [jboss-cvs] JBossAS SVN: r114837 - branches. Message-ID: <201505090211.t492BukB012676@svn01.web.mwc.hst.phx2.redhat.com> Author: dehort Date: 2015-05-08 22:11:55 -0400 (Fri, 08 May 2015) New Revision: 114837 Added: branches/JBPAPP_5_2_0_GA_JBPAPP-11221/ Log: [JBPAPP-11221] Creating a branch for a one-off patch From jboss-cvs-commits at lists.jboss.org Fri May 8 22:13:55 2015 From: jboss-cvs-commits at lists.jboss.org (jboss-cvs-commits at lists.jboss.org) Date: Fri, 8 May 2015 22:13:55 -0400 Subject: [jboss-cvs] JBossAS SVN: r114838 - branches/JBPAPP_5_2_0_GA_JBPAPP-11221/tomcat/src/main/org/jboss/web/tomcat/security. Message-ID: <201505090213.t492DtBZ012705@svn01.web.mwc.hst.phx2.redhat.com> Author: dehort Date: 2015-05-08 22:13:55 -0400 (Fri, 08 May 2015) New Revision: 114838 Modified: branches/JBPAPP_5_2_0_GA_JBPAPP-11221/tomcat/src/main/org/jboss/web/tomcat/security/JaccContextValve.java Log: [JBPAPP-11221] JBossWebRealm.hasRole throws a NullPointerException Modified: branches/JBPAPP_5_2_0_GA_JBPAPP-11221/tomcat/src/main/org/jboss/web/tomcat/security/JaccContextValve.java =================================================================== --- branches/JBPAPP_5_2_0_GA_JBPAPP-11221/tomcat/src/main/org/jboss/web/tomcat/security/JaccContextValve.java 2015-05-09 02:11:55 UTC (rev 114837) +++ branches/JBPAPP_5_2_0_GA_JBPAPP-11221/tomcat/src/main/org/jboss/web/tomcat/security/JaccContextValve.java 2015-05-09 02:13:55 UTC (rev 114838) @@ -96,13 +96,7 @@ } finally { - SecurityAssociationValve.activeWebMetaData.set(null); - ActiveRequestResponseCacheValve.activeRequest.set(null); - ActiveRequestResponseCacheValve.activeResponse.set(null); - SecurityAssociationActions.clear(); - activeCS.set(null); - SecurityRolesAssociation.setSecurityRoles(null); - HttpServletRequestPolicyContextHandler.setRequest(null); + cleanUp(); } } @@ -134,14 +128,17 @@ } finally { - SecurityAssociationValve.activeWebMetaData.set(null); - ActiveRequestResponseCacheValve.activeRequest.set(null); - ActiveRequestResponseCacheValve.activeResponse.set(null); - SecurityAssociationActions.clear(); - activeCS.set(null); - SecurityRolesAssociation.setSecurityRoles(null); - HttpServletRequestPolicyContextHandler.setRequest(null); + cleanUp(); } } - -} \ No newline at end of file + + private void cleanUp() { + SecurityAssociationValve.activeWebMetaData.set(null); + //ActiveRequestResponseCacheValve.activeRequest.set(null); + //ActiveRequestResponseCacheValve.activeResponse.set(null); + SecurityAssociationActions.clear(); + activeCS.set(null); + SecurityRolesAssociation.setSecurityRoles(null); + HttpServletRequestPolicyContextHandler.setRequest(null); + } +}