[jboss-dev-forums] [Deployers on JBoss (Deployers/JBoss)] - Re: Ordering of .ear subdeployments

[bstansberry@jboss.com]

I think with the latest change if an ear doesn't have a jboss-app.xml, deployment will fail with an NPE at EARDeployer line 275.  This is causing o.j.t.cluster.test.CrossContextCallsTestCase to fail.

I'd have just fixed this by changing 'if (moduleOrder.equals("strict"))' to 'if ("strict".equals(moduleOrder))' but I saw that in the else block it's logging a warning.  My recommendation would be to get rid of the warning (or log it at a lower level) and use the "strict".equals(...) syntax.  With this WARN log, anyone who upgrades to 4.0.5 and doesn't add this new config element will get a WARN log.  A WARN in a production app is a serious problem; to make it go away the users will have to add the new element. If they are going to have to add the element there is no point having a default.

Actually, "strict".equalsIgnoreCase(moduleOrder) would be better.


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3967666#3967666

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3967666