[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: Branch 1_0_XARecovery

[juha@jboss.org]

"timfox" wrote : 
  | 1) The call to persistenceManager.associateTxCallbackToPreparedTx() in TransactionRepository::loadPreparedTransactions()
  | 
  | seems to be redundant since the callback will be automatically created when the refs / acks are replayed.
  | 

However, removing it will cause the recovery to fail (messages are not delivered).

So if you think it is redundant then that failure to work correctly without the call needs to be investigated. That's why I've kept the related JIRA task on this still open.


"timfox" wrote : 
  | 
  | 2) TransactionRepository::handleReferences():
  | 
  | call to persistenceManager.getMessageIdForRef(txId)
  | 
  | you only seem to be returning the first message id, the transaction may contain many message adds - so
  | you need to retrieve them all.
  | 

Right. I was suspecting this based on the API but couldn't find any clear indication of this in the code.


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3990752#3990752

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3990752