[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: Valve on HAAspect

[timfox]

"clebert.suconic at jboss.com" wrote : I have locally changed ValveAspect to use readWriteLocks... But I think using org.jboss.messaging.util.Valve would be a better mechanism.
  | 
  | a parenthesis before starting (Valve is the same as creating a property failoverRunning on the Aspect, and if failoverRunning is true we will wait on notify until failover is finished. I just encapsulated such logic in a class instead of spread Objects and notifies on ValveAspect, so please do not compare it with java.util.concurrent or any other package like that)
  | 
  | 
  | Using readWriteLock will add synchronization into ValveAspect::invoke. Even readWriteLock requires synchronization while the use of Valve would minimize it.
  | 


How does the use of Valve minimise it? Valve still needs to be synchronised.


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3994953#3994953

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3994953