[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Client-side failover valve

[ovidiu.feodorov@jboss.com]

Clebert,

I would like to understand the logic behind the way you implemented the Valve.

Here are some questions:

1. I noticed that ValveAspect extends HAAspect but also implements Interceptor. Why do you need to extend HAAspect? Is the Valve construct an aspect (is it intended to encapsulate multiple advices) or it is essentially an interceptor (a single advice)?

2. I don't see a ValveAspect in aop-messaging-client.xml, which means you're using it in a non-standard way. You've got to decide whether it's an aspect/interceptor, and then you initialize it consistently with the rest of the stack, or it's something else, but in that case don't call it "aspect", call it something else.

3. Please write down (no more than three-four paragraphs) the way your client-side valve is intended to work.

Some general observations:

1. Please use the commonly-accepted coding style where you guard various sections of your class file with labels (// Constants ---, // Constructors ---, etc)
2. Make sure that after you check in the $Id$ tag is correctly updated. I noticed that in your case it isn't. It has something to do with your SVN client set-up, it happened to Tim as well, and he fixed it.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3996775#3996775

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3996775