[jboss-dev-forums] [Design of JBossCache] - Re: API Issues integrating 2.0.0.DR1 in HEAD

[bstansberry@jboss.com]

"manik.surtani at jboss.com" wrote : 
  | * What callback do I need to provide for the DI from the MC?
  | * The TM can be retrieved using the CacheSPI, again perhaps this could be downgraded to be accessible from Cache.  Accessing this from the Configuration doesn't make much sense since the Configuration should be a valid, testable and checkable object even when the cache is not running while the TM is a resource that should only be available when the cache is running.

I'd have to think about it if doing it through the configuration is no good (I agree w/ what you're saying about that.)  What I've been thinking about w/ the MC is to have it build the config and then create the cache via the factory.  I suppose once its done that it could inject the TM via a setTransactionManager method.  But that sounds like a hack.

This isn't a critical issue; the session repl thing is a bit of an odd case and I've got a (hacky) workaround for it.

anonymous wrote : anonymous wrote : 
  |   | 5) Why is Node.getChildren() a Collection and not a Set? I expect it's because Map.getValues() is a Collection, but properly this method should return Set.
  |   | 
  | 
  | You guessed why.  :-)  Does it make more sense as a Set?  I suppose so, since only one instance of each child would exist.  I'd need to think of an efficient way to do this though, as iterating and creating a new set every time getChildren() is called is sub-optimal.
  | 

Probably not worth it. I just mentioned it because I happened to notice it.

anonymous wrote : 
  | 6) The Node interface desribes various returned Collections as being immutable. From a glance at NodeImpl it looks like they aren't. Also, it would be good to be more clear about thread safety as immutable and thread safe aren't the same.
  | 

Which ones aren't?  I may have missed some.  The point is not for thread safety, but so changes go through the Node or Cache API and hence the interceptor stack.


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3978957#3978957

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3978957