[jboss-dev-forums] [Design of JBossCache] - Re: POJOization of config elements

[manik.surtani@jboss.com]

Re: #1, as Scott suggested, you shouldn't need a PropertyEditor for Enums with the MC. 

And Re: #3:

anonymous wrote : 
  | 
  | 
  | 3) Eviction configuration naming. The Pojo configuration looks like this:
  | 
  | class EvictionConfig -- top level object. Configure your default eviction policy here, plus the interval for the eviction thread. Also takes a list of...
  | 
  | class EvictionRegionConfig -- one per region. Configure the Fqn here, plus the class name of the EvictionPolicy (if you want to override the overall default). Also takes an impl of....
  | 
  | interface EvictionConfiguration. the type-specific config for the EvictionPolicy.
  | 
  | Couple problems here. First "EvictionConfiguration" would be better named "EvictionPolicyConfig", since its a config for a specific policy. But, that interface already exists in 1.4, so changing that name will break any existing custom impls. Don't know if we care about that. Second, there's already an unused interface named EvictionPolicyConfig, along with a DefaultEvictionPolicyConfig impl. That code is unused; looks like it was meant more as a top-level config object. We should drop that code after ensuring that any design ideas from it get picked up in the new stuff.
  | 
  | 
  | 

Yes, this stuff needs a bit of cleaning up.  I suggest:

1) Leave EvictionConfiguration as it is.
2) EvictionPolicyConfig extends EvictionConfiguration, and internally we use EvictionPolicyConfig.  We also document EvictionPolicyConfig and suggest that people use this, giving us a migration path.
3) Clean up on the unused code around here.  
4) Remove the now redundant EvictionPolicyClass attribute - as this is now set as a part of a Region.

What do you think?  I don't mind removing EvictionConfiguration altogether and breaking 1.4.0 compat as we're doing this in other areas anyway, but we aren't changing that much in the eviction policies so I'm not sure about this.



View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3980308#3980308

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3980308