[jboss-dev-forums] [Design of POJO Server] - Re: WarDeployer dependency on TomcatClusteringCache

[scott.stark@jboss.org]

What I am saying is that these should not be expressed as dependencies on the WarDeployer. They are the defaults for dependencies that one would describe in a jboss-web.xml. To start the war deployer I don't need any of these other services. So this:


  |    <bean name="WarDeployer" class="org.jboss.web.tomcat.tc6.deployers.TomcatDeployer">
  | ...
  | 	<property name="securityManagerService">
  | 			<inject bean="jboss.security:service=JaasSecurityManager" />
  | 	   </property>
  |       <depends>jboss.cache:service=TomcatClusteringCache</depends>
  |       
  |       <depends>jboss:service=TransactionManager</depends>
  |       
  |       <!-- Only needed if the org.jboss.web.tomcat.tc6.jca.CachedConnectionValve
  | TODO: injection
  |       is enabled in the tomcat server.xml file.
  |       <depends>jboss.jca:service=CachedConnectionManager</depends>
  |       -->
  |    </bean>
  | 

should be something like:

  |    <bean name="WarDeployer" class="org.jboss.web.tomcat.tc6.deployers.TomcatDeployer">
  | ...
  |       <property name="defaultSecurityManagerService">jboss.security:service=JaasSecurityManager</property>
  |       <property name="defaultCacheService">jboss.cache:service=TomcatClusteringCache</property>
  |       <property name="defaultTM">jboss:service=TransactionManager</property>
  |      
  |    </bean>
  | 

These would then be added to each WebMetaData depends list. We need to update the WebModule mbean to expose accessors for these services so that the dependency can be injected and the WebModule can perform the related configuration. This is the minimal necessary refactoring of the WarDeployer.

The CachedConnectionValve should be the one expression the injection of the CachedConnectionManager. A similar situation exists with the JBossContextConfig in that the authenticators should be declared directly on it rather than propagated from the WarDeployer via jmx. How we work around this in the interim of tomcat supporting injection of pojos is a todo.



View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3982198#3982198

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3982198