[jboss-dev-forums] [Design of POJO Server] - Re: VFS isLeaf() vs isDirectory()/isFile()

[scott.stark@jboss.org]

"adrian at jboss.org" wrote : Rather than arguing about and disagreeing, I'd suggest we write some
  | tests for the use cases and implement it.
  | 
  | It sounds like both approaches would work and have different use cases.
  | 
  | 1) Being able to attribute a VirtualFile with deployment attributes
  | and have the structure deployer check the attribute(s).
  | 
  | 2) Being able define your own structure by predetermined
  | deployment contexts.
  | 
  | I still think (2) is simpler.
  | And more generic since it doesn't require the construction
  | of metadata files when you already have the metadata object in memory
  | i.e. constructed on the fly.
  | 
  | It is also unclear to me how the attributes in (1) are
  | persisted in general? i.e. going beyond the case where
  | the ide can remember these in some ide config file.
  | 
I agree that we need a real demonstration of how the proposed apis are used as in the end that is the determining factor. I don't see that (1) precludes (2). Its just more information into a structural analysis pass, which is still something a naive user of the deployment layer (like the jsr88/profile service) need to be able to translate deployment urls into deployable objects.

In terms of allowing attributes on files, the api will have to support adding them, and how/if they are stored an impl detail of the VFS. 

"adrian at jboss.org" wrote : 
  | Removing the isArchive() from the VFS layer, requires
  | the changes I suggested.
  | 
  | However, just ignoring the unrecognised structure means
  | it will not appear in the summary IncompleteDeployments
  | unless that processing is extended to include them somehow?
  | 
I don't see why having the unkown virtual file show up in the IncompleteDeployments is a needed element. In this case we are talking about multiple deployments, not an uknown element inside a top level deployment. How this is handled is purely a VFScanner detail as far as I can see. 


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3975146#3975146

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3975146