[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: http://jira.jboss.org/jira/browse/JBMESSAGING-808 - Fail

[timfox]

Looks good.

But when you make changes don't just comment things out, get rid of them if they are not needed.


  |             if (rows != 1)
  |             {
  |                // http://jira.jboss.com/jira/browse/JBMESSAGING-808
  |                log.warn("Failed to remove row for: " + ref);
  |                return;
  |                //throw new IllegalStateException("Failed to remove row for: " + ref);
  |             }
  | 

Otherwise we end up with the code scattered with rubbish.

If we want to retrieve the previous version, it's in version control.

I'm not sure if the log.warn is really necessary either.

log.warn would imply there is probably something wrong. Is this the case?

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4010404#4010404

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4010404