[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: JBMESSAGING-674 - Propagating changes on ClusteredConnec

[timfox]

I've finally managed to look at the new code.

A few questions:

1. The update information is sent from server to client in a ConnectionFactoryUpdateMessage instance. This needs to be wrapped in a MessagingMarshallable, otherwise we can't version it.

2. ServerConnectionFactoryEndpoint::updateclusteredClients() is currently only called when a connection factory is deployed / undeployed. It is not called when a node joins or leaves the cluster. It needs to be called in this case too.
Also you need to add tests to check that the update occurs in this situation.

3. Why have you made MessageCallbackHandler and ConnetionFactoryCallbackHandler implement the same (new) interface (CallbackHandler) ? This seems redundant since they are never called polymorphically anyway.

4. I was unsure why init() was being called on the ClientClusteredConnectionFactoryDelegate every time a failover view change occurred...

Cheers


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4004237#4004237

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4004237