[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: JBMESSAGING-674 - Propagating changes on ClusteredConnec

[clebert.suconic@jboss.com]

"timfox" wrote : 
  | 1. The update information is sent from server to client in a ConnectionFactoryUpdateMessage instance. This needs to be wrapped in a MessagingMarshallable, otherwise we can't version it.
  | 


Ok... I will change this.


"timfox" wrote : 
  | 2. ServerConnectionFactoryEndpoint::updateclusteredClients() is currently only called when a connection factory is deployed / undeployed. It is not called when a node joins or leaves the cluster. It needs to be called in this case too.
  | Also you need to add tests to check that the update occurs in this situation.
  | 


Are you sure about this? I have testcases about this... a testcase that gets the ConnectionFactory updated when a new server joins / leaves the cluster.


"timfox" wrote : 
  | 3. Why have you made MessageCallbackHandler and ConnetionFactoryCallbackHandler implement the same (new) interface (CallbackHandler) ? This seems redundant since they are never called polymorphically anyway.
  | 


I didn't want MessageCallbackHandler to also take care of ConnectionFactories... I thought the dependency would be wrong.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4004607#4004607

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4004607