[jboss-dev-forums] [Other JBoss Development Design] - Re: failing org.jboss.test.util.test.ThreadPoolRunnableUnitT

[scott.stark@jboss.org]

The source is clearly different, with the brew version clearly missing two changes. This is a source tree older than 1.3.4 to be sure:


  | [starksm at succubus oswego-concurrent]$ diff -w 1.3.4/lib/src/EDU/oswego/cs/dl/util/concurrent/PooledExecutor.java 1.3.4-brew/src/concurrent/PooledExecutor.java
  | 30,31d29
  | <   30aug2003  dl               check for new tasks when timing out
  | <   18feb2004  dl               replace dead thread if no others left
  | 190,193c188
  | <  *     <dd> Wait until a thread becomes available.  This
  | <  *          policy should, in general, not be used if the minimum number of
  | <  *          of threads is zero, in which case a thread may never become
  | <  *          available.
  | ---
  | >  *     <dd> Wait until a thread becomes available.
  | 298c293
  | <  *  <li> Same as (2) except clients abort if both the buffer is full and
  | ---
  | >  *  <li> Same as (2) except clients block if both the buffer is full and
  | 304c299
  | <  *        pool.abortWhenBlocked();
  | ---
  | >  *        pool.waitWhenBlocked();
  | 699,709d693
  | <
  | <     // Create a replacement if needed
  | <     if (poolSize_ == 0 || poolSize_ < minimumPoolSize_) {
  | <       try {
  | <          Runnable r = (Runnable)(handOff_.poll(0));
  | <          if (r != null && !shutdown_) // just consume task if shut down
  | <            addThread(r);
  | <       } catch(InterruptedException ie) {
  | <         return;
  | <       }
  | <     }
  | 794,797d777
  | <       synchronized(PooledExecutor.this) {
  | <         if (shutdown_)
  | <           return true;
  | <       }
  | 805,806c785
  | <    * is available, unless the pool has been shut down, in which case
  | <    * the action is discarded.
  | ---
  | >    * is available.
  | 


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4031157#4031157

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4031157