[jboss-dev-forums] [Design of POJO Server] - Re: Issues with EJB2 ClusterConfigMetaData

[scott.stark@jboss.org]

"bstansberry at jboss.com" wrote : 
  | 1) Class exposes properties home(bean)LoadBalancingPolicy.  DTD says they should be home(bean)LoadBalancePolicy (Balance not Balancing).  
  | 
  | That's a simple fix I've already made in my workspace; please advise if I should check it in; don't want to step on people.
  | 
fine, in the metdata project right?

"bstansberry at jboss.com" wrote : 
  | 2) The way ClusterConfigMetaData.determineHome(Bean)LoadBalancingPolicy() work, you only get the default policy if you added a cluster-config element to your bean declaration in jboss.xml.  If the ClusterConfigMetaData came from a container-configuration, you *don't* get any default.  You get null unless the value was specifically set in the relevant container-configuration/cluster-config element. This leads to test failures.  A simple workaround to fix the test failures is to add the default policies to standardjboss.xml.
  | 
The default really should come from the container config. There still is too much logic in the ClusterConfigMetaData, and in fact I don't think we should be associating the ClusterConfigMetaData with a JBossEnterpriseBeanMetaData instance to figure out defaults based on bean type. We need a merge(ClusterConfigMetaData) added to ClusterConfigMetaData to merged the standardjboss.xml config into a partial jboss.xml config.

"bstansberry at jboss.com" wrote : 
  | 3) (I could be wrong about this; haven't tested, just looked at code. So, take this as more about how it should work). If you do something like this:
  | ...
  | Your bean will end up using RoundRobin instead of RandomRobin.  AFAICT, the code checks the bean's config, and if not set goes to a hard coded default.
  | 
  | Wouldn't it be better to pull the default from the container-configuration?  If that's agreeable I can do that.
  | 
  | 4) If yes to last question, that suggests there shouldn't be a hard coded default at all; the defaults should come from a container-configuration, ultimately from standardjboss.xml.


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4101973#4101973

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4101973