[jboss-dev-forums] [Design of POJO Server] - Re: ServiceDeployer.deploy not seeing deployment errors

[adrian@jboss.org]

"scott.stark at jboss.org" wrote : The http://jira.jboss.com/jira/browse/JBAS-4684 issue is due to the ServiceDeployer.deploy method not seeing the deployment error. This is due to the AbstractController.incrementState uninstalling context with errors:
  | 
  | 
  |   | ...
  |   |       finally
  |   |       {
  |   |          lockWrite();
  |   |          if (error != null)
  |   |          {
  |   |             log.error("Error installing to " + toState.getStateString() + ": " + context.toShortString(), error);
  |   |             uninstallContext(context, ControllerState.NOT_INSTALLED, trace);
  |   |             errorContexts.put(context.getName(), context);
  |   |             context.setError(error);
  |   |             return false;
  |   |          }
  |   |       }
  |   | 
  | 

Looks to me like it is setting the error after it has done the uninstallContext()
so I don't see why this wouldn't show up in the checkComplete()?

NOTE: If this is the checkComplete(Deployment) rather than the full checkComplete()
that does not look at the contexts created by the deployment, it is a TODO item.

anonymous wrote : 
  | The context after the ServiceDeployer.deploy calls start(context), the context is in a DESTROYED state, but has no problem set:
  | 
  |   | ObjectName: jboss.web.deployment:war=/custom-context
  |   |   State: DESTROYED
  |   | 
  | 
  | Because of this, the MainDeployer.checkComplete call has no information about the failed deployment. 
  | If I just fail to null out the ServiceContext.problem then the deployment failure propagates as expected.
  | 

That looks like a cut and paste error to me? i.e. uninstall() was copied from install()
and the nulling of the error was not removed.
We just haven't seen it before because of the setting of the error after uninstallContext()
above.

anonymous wrote : 
  | However, it seem like we should not be able to transition out of the ERROR state to DESTROYED?
  | 

That is only on the old ServiceContext (which isn't used for the checkComplete())
It is not being maintained properly because the setError() hasn't been invoked yet.
The real ServiceControllerContext should be in the ERROR state?

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4083351#4083351

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4083351