[jboss-dev-forums] [Design of EJB 3.0] - Re: EJBTHREE-1423 Test case for @RemoteBinding

[ALRubinger]

Good job, you've exposed https://jira.jboss.org/jira/browse/JBMETA-91, which I'll get into the next release (1.0.0.Beta36) this weekend assuming no regression in other dependent testsuites.

Using current SNAPSHOT of jboss-metadata, I've now got all these tests passing locally.

Some change requests to your patch (mostly housekeeping):

* build/pom.xml .. let's keep that out of scope.  I've updated the jboss-metadata dependency in SVN.
* Add to setupBeforeClass the boilerplate for deploying *-aop.xml, example in JndiSessionRegistrarTestCaseBase (else tests will fail)
* Add tests that the explicit addresses are also unbound upon undeploy

Also, the package name / class name of the test could be more in-line with those you've done for JndiSessionRegistrarTestCaseBase; they both test pretty much the same thing, only difference is that this new one uses explicit bindings as opposed to the default.  Maybe they could be merged?  I'd just like it to be ultra-clear what these tests do from their names alone (JndiSessionRegistrarTestCaseBase sounds pretty vauge).  Open to your suggestions here and then we'll move things around to be friendlier.

S,
ALR


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4169740#4169740

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4169740